Merge lp:~jason-hobbs/charms/trusty/cinder/log-lvm-info into lp:~openstack-charmers-archive/charms/trusty/cinder/next
Proposed by
Jason Hobbs
Status: | Merged |
---|---|
Merged at revision: | 107 |
Proposed branch: | lp:~jason-hobbs/charms/trusty/cinder/log-lvm-info |
Merge into: | lp:~openstack-charmers-archive/charms/trusty/cinder/next |
Diff against target: |
128 lines (+28/-1) 2 files modified
hooks/cinder_utils.py (+11/-0) unit_tests/test_cinder_utils.py (+17/-1) |
To merge this branch: | bzr merge lp:~jason-hobbs/charms/trusty/cinder/log-lvm-info |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Corey Bryant (community) | Approve | ||
Review via email: mp+265437@code.launchpad.net |
Commit message
Add logging of LVM info at critical points during setup.
Description of the change
This logging was useful for me in debugging LVM issues in our deployments. The state of PVs really determines how the charm is going to behave when setting up LVM, and without knowing what it was when the charm ran, it's hard to debug issues. It only generates a few lines of output everytime it's logged, so there's really no downside.
To post a comment you must log in.
charm_lint_check #6565 cinder-next for jason-hobbs mp265437
LINT FAIL: lint-test failed
LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.
Full lint test output: http:// paste.ubuntu. com/11916244/ 10.245. 162.77: 8080/job/ charm_lint_ check/6565/
Build: http://