Merge ~jarnos/ppa-purge:master into ppa-purge:master
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| ppa-purge | 2016-12-12 | Pending | |
|
Review via email:
|
|||
Description of the Change
Uses apt-get, not aptitude at all.
Aims to fix:
Under https:/
Bug #1614160
Bug #802853
Bug #1121325 (since it does not use aptitude)
Under https:/
Bug #1408031
Bug #1548881
Bug #995113
+some fixes told in git log.
Donate to me on contributing to this project: https:/
- f302251... by Jarno Suni on 2016-12-14
- 41b8698... by Jarno Suni on 2016-12-14
- dcbd763... by Jarno Suni on 2016-12-14
- 7d5a2cf... by Jarno Suni on 2016-12-15
| Tim (darkxst) wrote : | # |
| Tim (darkxst) wrote : | # |
s/subsequent/
| Jarno Suni (jarnos) wrote : | # |
Unfortunately development was not completely straight-forward.
| Tim (darkxst) wrote : | # |
there are still commits you could squash to clean things up a bit
&&
complete
you remove then add back
there 2 commits that deal with escaping ppa string?
etc
| Jarno Suni (jarnos) wrote : | # |
Is there an easy way to cancel the removing of && so that there is no mention of it in git log disturbing your mind?
Is it a problem that there are 2 commits that deal with escaping ppa string? If you want less commits I could just commit the final code as one commit. But you did not accept that either.
- 65fb9fb... by Jarno Suni on 2016-12-18
- 5bece79... by Jarno Suni on 2016-12-18
- 60a3ad1... by Jarno Suni on 2016-12-18
- 9e7bb54... by Jarno Suni on 2016-12-18
| Tim (darkxst) wrote : | # |
It is very easy
you need to use `git rebase -i HEAD~40` the last number is the amount of
commits to go back.
then you can group the commits you want to merge (cut and paste the line
and put it where it needs to go)
set the second commits action (first column) to s (squash)
It will then merge those commits, if there are any conflicts in the auto
merge it might leave little snippets in the code that you need to
manually correct. These will look something like
>>>>>>>>>> HEAD
old code
========
new code
<<<<<<<<<< later commit
Fix those, then "git add <file>"
git rebase --continue
update the commit message for the merged commit and its done!
If you want to just remove commits (for example the commit that adds
check ubuntu dists, then the other that subsequently removes it)
use the same "git rebase -i" command and then just delete the lines for
any commits to remove.
you can also you the e (edit) action if you ever need to make any change
to a particular commit!
On 19/12/16 00:31, Jarno Suni wrote:
> Is there an easy way to cancel the removing of && so that there is no mention of it in git log disturbing your mind?
>
> Is it a problem that there are 2 commits that deal with escaping ppa string? If you want less commits I could just commit the final code as one commit. But you did not accept that either.
>
>
> Diff comments:
>
>> diff --git a/ppa-purge b/ppa-purge
>> index a0b5e42..f197c2c 100755
>> --- a/ppa-purge
>> +++ b/ppa-purge
>> @@ -23,116 +38,196 @@ warn() {
>> write_msg "Warning: $*" 1>&2
>> }
>>
>> +error() {
>> + write_msg "Error: $*" 1>&2
>> +}
>> +
>> +apt_update() {
>> + msg "Updating package lists. This might take a while..."
>> + $APT $quiet_arg update
>> + exit_status=$?
>> + [[ $exit_status -eq 0 ]] &&
>> + msg "Updating package lists finished successfully." || {
>> + local -r text="Updating package lists failed; error code $exit_status."
>> + if [[ $yes ]]; then
>> + error "$text"
>> + [[ $quit ]] || exit 5
>> + else
>> + warn "$text"
>> + [[ $quit ]] || {
>> + read -p "Continue anyway (y/n)? " -n 1 -r
> Yes, I could remove it, I suppose.
>
>> + echo
>> + [[ $REPLY =~ ^[Yy]$ ]] || exit 5
>> + }
>> + fi
>> + }
>> +}
>> +
>> +finish() {
>> + quit=t
>> + rm $PPA_PKGS $REVERTS
>> + if [[ $restore && ((${#lists[@]} > 0)) ]]; then
>> + msg 'Restoring .list file(s):'
>> + for file in "${lists[@]}"; do
>> + cp -va "$file".save "$file"
>> + done
>> + apt_update
>> + fi
>> +}
>> +
>> +trap finish 0
>> +
>> usage() {
>> - echo "Usage: sudo ppa-purge [options] <ppa:ppaowner>
>> - echo
>> - echo "ppa-purge will reset all packages from a PPA to the standard"
>> - echo "versions released for your distribution."
>> - echo
>> - echo "Options:"
>> - echo " -p [ppaname] PPA name to be disabled (default: ppa)"
>> - echo " -o [ppaowner] PPA owner"
>> - echo " -s [host] Repository server (default: ppa.launchpad.net)"
>> - echo " -d [distribution] Override the default distribution choice."
>> - echo " -y Pass "-y --force-yes" to apt-get or "-y" to aptitude"
>> - echo " -i Reverse preference of apt-get upon aptitude."
>> - echo " -h Display this help text"
>> -...
- 2db960c... by Jarno Suni on 2016-12-20
- 4744e12... by Jarno Suni on 2016-12-21
- b51c9e1... by Jarno Suni on 2016-12-22
- 3e937ff... by Jarno Suni on 2016-12-23
| Jarno Suni (jarnos) wrote : | # |
I did the changes you suggested, but I was in another branch, and to my surprise, the changes do not show in master. BTW I also changed the first commit to include (all?) remarkable authors, but that again does not show in master.
| Jarno Suni (jarnos) wrote : | # |
I thought the changes would go to each branch since all of them were same up to those commits before changing.
| Tim (darkxst) wrote : | # |
you need to push a new branch after rebasing!
| Jarno Suni (jarnos) wrote : | # |
On Sat, 24 Dec 2016 04:38:45 -0000
Tim <email address hidden> wrote:
> you need to push a new branch after rebasing!
You mean the feature branch I created for enabling long options and
removing distributions? Where could I push that one or do you mean I
merge it to my local master and then push?
--
Jarno Ilari Suni - http://
| Tim (darkxst) wrote : | # |
any branch in general, when you rebase it destroys the history and needs to be re-pushed. you can force overwrite an existing branch but if
anyone is using that, they will have issues!
On 25/12/16 07:12, Jarno Suni wrote:
> On Sat, 24 Dec 2016 04:38:45 -0000
> Tim <email address hidden> wrote:
>
>> you need to push a new branch after rebasing!
> You mean the feature branch I created for enabling long options and
> removing distributions? Where could I push that one or do you mean I
> merge it to my local master and then push?
>
- 5f63cfe... by Jarno Suni on 2016-12-31
- abb9aa4... by Jarno Suni on 2016-12-31
- a14bb53... by Jarno Suni on 2016-12-31
- fef559f... by Jarno Suni on 2017-01-03
- 89b15ea... by Jarno Suni on 2017-01-04
| Jarno Suni (jarnos) wrote : | # |
I have not succeeded in pushing the feature branch where the changes are made anywhere. I am afraid it is hard to merge to the master branch, but I could try.
| Jarno Suni (jarnos) wrote : | # |
Could I delete the current master, and make the feature branch new master somehow?
| Tim (darkxst) wrote : | # |
has it been rebased on master?
if so then that is fine.
On 21/02/17 22:55, Jarno Suni wrote:
> Could I delete the current master, and make the feature branch new master somehow?
| Jarno Suni (jarnos) wrote : | # |
I used this procedure to make the feature branch the new master: http://
Commits of the old master are shown in log, but they are not used if I understood correctly.
| Jarno Suni (jarnos) wrote : | # |
I wonder, if there are any issues, if I remove the commits of the old master?
| Jarno Suni (jarnos) wrote : | # |
This version may downgrade ppa-purge itself, but not purge it.
| Jarno Suni (jarnos) wrote : | # |
Hello,
How are you? Do you still miss a proper internet connection or what is
keeping you from reviewing the changes?
-Jarno
On Wed, 22 Feb 2017 07:15:44 -0000
Tim <email address hidden> wrote:
> has it been rebased on master?
>
> if so then that is fine.
>
>
>
> On 21/02/17 22:55, Jarno Suni wrote:
> > Could I delete the current master, and make the feature branch new
> > master somehow?
>
>
--
Jarno Ilari Suni - http://
| Tim (darkxst) wrote : | # |
Yes still without proper internet should have ADSL in a few weeks
so,will take a look then. Sorry about the delay
On Wed, Apr 26, 2017, at 07:06 AM, Jarno Suni wrote:
> Hello,
>
> How are you? Do you still miss a proper internet connection or what is
> keeping you from reviewing the changes?
>
> -Jarno
>
>
> On Wed, 22 Feb 2017 07:15:44 -0000
> Tim <email address hidden> wrote:
>
> > has it been rebased on master?
> >
> > if so then that is fine.
> >
> >
> >
> > On 21/02/17 22:55, Jarno Suni wrote:
> > > Could I delete the current master, and make the feature branch new
> > > master somehow?
> >
> >
>
>
>
> --
> Jarno Ilari Suni - http://
>
> https:/
> Your team ppa-purge is requested to review the proposed merge of
> ~jarnos/
--
Tim Lunn
<email address hidden>
| Jarno Suni (jarnos) wrote : | # |
There seem to be some conflicts. Is it because you have added few commits in master after I made this merge proposal? My changes have parent commit 9dbd19d24294cd8
- 4b42b42... by Jarno Suni on 2017-05-01
| Jarno Suni (jarnos) wrote : | # |
I force pushed some small changes.
| Jarno Suni (jarnos) wrote : | # |
It may be unnecessary to check for warnings in apt_update(). See https:/
- cc0e6e1... by Jarno Suni on 2017-08-05
| Jarno Suni (jarnos) wrote : | # |
My bash completion implementation is maybe too complicated as it shows '--verbose=0', '--verbose=1' and '--verbose=2' directly as completion of '--'. I could simplify that.
| Jarno Suni (jarnos) wrote : | # |
Tim, do you have ADSL now after more than 3 months? I do not see why ADSL connection is so critical to you and why it is so hard for you the get internet connection for this reviewing task. (I had ADSL in the past, but the over-head wire was taken away, and I have used 4G ever since.)
Unmerged commits
- cc0e6e1... by Jarno Suni on 2017-08-05
- 4b42b42... by Jarno Suni on 2017-05-01
- 89b15ea... by Jarno Suni on 2017-01-04
- fef559f... by Jarno Suni on 2017-01-03
- a14bb53... by Jarno Suni on 2016-12-31
- abb9aa4... by Jarno Suni on 2016-12-31
- 5f63cfe... by Jarno Suni on 2016-12-31
- 4744e12... by Jarno Suni on 2016-12-21
- 3e937ff... by Jarno Suni on 2016-12-23
- b51c9e1... by Jarno Suni on 2016-12-22

Turns out this is pretty hard to review, launchpad doesnt help but you also have several commits that revert or fix changes you made in subsequent commits.
Have made a couple of inline comments below.
Will also go through and cherry-pick some of the more trivial commits, but you will need to rebase your branch once done.