Merge lp:~janez-troha/nuvola-player/8tracks into lp:nuvola-player/2.5.x

Proposed by dz0ny
Status: Merged
Approved by: Jiří Janoušek
Approved revision: 109
Merged at revision: 113
Proposed branch: lp:~janez-troha/nuvola-player/8tracks
Merge into: lp:nuvola-player/2.5.x
Diff against target: 169 lines (+87/-4) (has conflicts)
4 files modified
data/google-music-frame/scripts/eighttracks.js (+2/-2)
src/application.vala (+1/-1)
src/settings.vala (+9/-1)
src/window.vala (+75/-0)
Text conflict in src/window.vala
To merge this branch: bzr merge lp:~janez-troha/nuvola-player/8tracks
Reviewer Review Type Date Requested Status
Jiří Janoušek Pending
Review via email: mp+82830@code.launchpad.net

Description of the change

Global menu

To post a comment you must log in.
Revision history for this message
Jiří Janoušek (fenryxo) wrote :

I've already started to transform toolbar to menu, but I wil definitely combine my and your code. Thanks.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/google-music-frame/scripts/eighttracks.js'
2--- data/google-music-frame/scripts/eighttracks.js 2011-11-19 17:31:18 +0000
3+++ data/google-music-frame/scripts/eighttracks.js 2011-11-20 21:53:25 +0000
4@@ -208,7 +208,7 @@
5
6 $GMF.prototype.thumbsUp = function(){
7 try{
8- window.Grooveshark.voteCurrentSong(1);
9+
10 }
11 catch(e){
12 $throw_exception(e.message);
13@@ -217,7 +217,7 @@
14
15 $GMF.prototype.thumbsDown = function(){
16 try{
17- window.Grooveshark.voteCurrentSong(-1);
18+
19 }
20 catch(e){
21 $throw_exception(e.message);
22
23=== modified file 'src/application.vala'
24--- src/application.vala 2011-11-19 23:27:27 +0000
25+++ src/application.vala 2011-11-20 21:53:25 +0000
26@@ -274,7 +274,7 @@
27 this.media_keys.handle_multimedia_keys();
28 else
29 this.media_keys.release_multimedia_keys();
30-
31+ //TODO: handle change for toolbar
32 }
33
34 /**
35
36=== modified file 'src/settings.vala'
37--- src/settings.vala 2011-11-08 20:52:13 +0000
38+++ src/settings.vala 2011-11-20 21:53:25 +0000
39@@ -70,6 +70,8 @@
40 box.pack_start(this.create_bool_entry("pause_key", _("Use Pause (break) key to toggle play/pause"), false), false, false);
41 /// Settings dialog - tab General
42 box.pack_start(this.create_bool_entry("hide_when_playing", _("Hide window if close button is clicked while playing."), true), false, false);
43+ /// Settings dialog - tab General
44+ box.pack_start(this.tool_bar("show_control_toolbar", _("Show controll bar in main window."), true), false, false);
45 // TODO: option "Show tray icon or sound menu entry"
46
47
48@@ -151,7 +153,13 @@
49 entry.toggled.connect(() => { this.set_bool(key, entry.active); });
50 return entry;
51 }
52-
53+
54+ private CheckButton tool_bar(string key, string label, bool default){
55+ var entry = new CheckButton.with_label(label);
56+ entry.active = this.app.config.bool(key, default);
57+ entry.toggled.connect(() => { this.set_bool(key, entry.active); });
58+ return entry;
59+ }
60
61 private void proxy_toggled(ToggleButton button){
62 log_debug("Proxy button toggled");
63
64=== modified file 'src/window.vala'
65--- src/window.vala 2011-11-19 23:27:27 +0000
66+++ src/window.vala 2011-11-20 21:53:25 +0000
67@@ -27,6 +27,7 @@
68 public class MainWindow : Gtk.Window{
69 private Application app;
70 private Toolbar bar;
71+ private MenuBar menubar;
72 private Box box;
73 private ScrolledWindow win;
74
75@@ -53,6 +54,70 @@
76 log_warning("Unable to load application icon.");
77 }
78
79+ //Globalmenu
80+ this.menubar = new MenuBar();
81+
82+
83+ //Nuvola
84+ var nuvola_group = new Menu();
85+ var nuvola = new MenuItem.with_mnemonic("_Nuvola");
86+ nuvola.set_submenu(nuvola_group);
87+ this.menubar.add(nuvola);
88+
89+ //actions for nuvola group
90+ var go_home_action = new Gtk.Action("home",null,null,Gtk.Stock.HOME);
91+ go_home_action.activate.connect(() => { this.go_home_action(); });
92+ nuvola_group.add(go_home_action.create_menu_item());
93+
94+ var refresh_action = new Gtk.Action("refresh",null,null,Gtk.Stock.REFRESH);
95+ refresh_action.activate.connect(() => { this.refresh_action(); });
96+ nuvola_group.add(refresh_action.create_menu_item());
97+
98+ var quit_action = new Gtk.Action("quit", null, null, Gtk.Stock.QUIT);
99+ quit_action.activate.connect(() => {
100+ try{
101+ this.hide();
102+ this.app.quit();
103+ }
104+ catch(Fenryxo.AppError e){
105+ log_critical("Unable to quit: %s", e.message);
106+ }
107+ });
108+ nuvola_group.add(quit_action.create_menu_item());
109+
110+ //Options
111+ var options_group = new Menu();
112+ var options = new MenuItem.with_mnemonic("_Options");
113+ options.set_submenu(options_group);
114+ this.menubar.add(options);
115+
116+ var troubleshooting_action = new Gtk.Action("istrouble",_("Troubleshooting"),null,null);
117+ troubleshooting_action.activate.connect(() => { this.troubleshooting_action(); });
118+ options_group.add(troubleshooting_action.create_menu_item());
119+
120+ var settings_action = new Gtk.Action("pref", null, null, Gtk.Stock.PREFERENCES);
121+ settings_action.activate.connect(() => { this.settings_action(); });
122+ options_group.add(settings_action.create_menu_item());
123+
124+ var switch_service_action = new Gtk.Action("switch",_("Switch service"),null,null);
125+ switch_service_action.activate.connect(() => { this.switch_service_action(); });
126+ options_group.add(switch_service_action.create_menu_item());
127+
128+ //Help
129+ var help_group = new Menu();
130+ var help = new MenuItem.with_mnemonic("_Help");
131+ help.set_submenu(help_group);
132+ this.menubar.add(help);
133+
134+ var visit_action = new Gtk.Action("help",_("Visit site"),null,Gtk.Stock.HELP);
135+ visit_action.activate.connect(() => { });
136+ help_group.add(visit_action.create_menu_item());
137+
138+ var show_about_dialog = new Gtk.Action("about", null, null, Gtk.Stock.ABOUT);
139+ show_about_dialog.activate.connect(() => { this.show_about_dialog(); });
140+ help_group.add(show_about_dialog.create_menu_item());
141+
142+ //other menu
143 this.bar = new Toolbar();
144 this.bar.toolbar_style = ToolbarStyle.TEXT;
145 ToolButton item;
146@@ -97,13 +162,23 @@
147 this.bar.add(item);
148
149 this.box = new Gtk.VBox(false, 2);
150+<<<<<<< TREE
151 this.box.pack_start(this.bar, false);
152 this.win = new ScrolledWindow(null, null);
153 this.win.set_policy (PolicyType.AUTOMATIC, PolicyType.AUTOMATIC);
154 this.box.pack_start(this.win);
155 this.add(this.box);
156+=======
157+ this.box.pack_start(this.menubar, false);
158+ if(this.app.config.bool("show_control_toolbar", true)){
159+ this.box.pack_start(this.bar, false);
160+ }
161+ base.add(this.box);
162+>>>>>>> MERGE-SOURCE
163 this.box.show_all();
164
165+
166+
167
168 /* Restore last window dimensions */
169 int w = 0;

Subscribers

People subscribed via source and target branches