Merge lp:~jan-philipp-fischer/openerp-connector-magento/7.0-strip-html into lp:~openerp-connector-core-editors/openerp-connector-magento/7.0

[Jan-Philipp Fischer]

Strips HTML Tags from description and sale_description.

Addes a general modifier for that.

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

Hi Jan,
Thanks for the contribution. Can you fix the copyright?
You are the author of the change, be proud of your work ;)

You have some pep-8 issue in the file mapper.py

- miss a blank line before the "class MLStriper" (always 2 blank line before a class)
- miss a blank line before the "def...."
- remove the last blank line at the end of the file.

(Note I use https://github.com/nbessi/openerp-conventions ;) )

Fix the pep8 issue and it will be ok for me

review: Approve (no test, code review)

[Sébastien BEAU - http://www.akretion.com (sebastien.beau)]

oups sorry wrong status. A small need fixing for the pep8 issue

review: Needs Fixing

[lp:~jan-philipp-fischer/openerp-connector-magento/7.0-strip-html]

965. By Jan-Philipp Fischer on 2014-05-04

[FIX] Copyright and pep-8 issues

[Jan-Philipp Fischer (jan-philipp-fischer)]

Hi Sébastien,

i changed the file. Thanks for you review:)

review: Needs Resubmitting

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Hi Jan-Philipp,

The MLStripper puts only 1 line break between paragraphs, when we could expect a blank line. Do you know if this can be changed?

As an alternative, you can use the html2text lib which is embedded in openerp.addons.email_template. It does something sligtly different though: it transforms the html to a markdown-like syntax (so <b>hello world</b> becomes **hello world**), but is it something we could expect in the descriptions? In my opinion, using html2text could be nice.

A note about the 'Resubmit': as the one who proposed the merge, you should not use the 'Resubmit' review, it is usually used by reviewers when they *ask* for a resubmit.

review: Needs Fixing

[lp:~jan-philipp-fischer/openerp-connector-magento/7.0-strip-html]

966. By Jan-Philipp Fischer on 2014-06-11

Using html2text

[Jan-Philipp Fischer (jan-philipp-fischer)]

Updated to html2text. You're right. It is nice.

Aren't able to test it in OpenERP at the moment. But tested it with normal python and it worked.
If someone can test it in OpenERP it would be nice.

Thanks!

[Philippe B (philippe-j)]

Why we can't keep the html tags in openerp with an editor embed so you can make beautiful descriptions to export them to magento like you can do it with saas3
Philippe
sorry for my french english

[Jan-Philipp Fischer (jan-philipp-fischer)]

Hi Philippe,

I don't know a way for getting such an editor into OpenERP (Odoo).

Do you?

[Markus Schneider (markus-schneider)]

Fields.html would do the job.

The problem is we need to change a basic field of product.product and if you are not using webkit it can breaks your sale.order report. But as a seperat module it would be possible
--
Dipl.-Comp.-Math. Markus Schneider
Softwareentwickler

initOS GmbH & Co. KG
An der Eisenbahn 1
21224 Rosengarten

Mobil: [phone]
Phone: [phone]
Fax: [phone]

Email: <email address hidden>
Web: http://www.initos.com

Geschäftsführung:
Dipl. Wirt.-Inf. Frederik Kramer & Dipl.-Ing. (FH) Torsten Francke
Haftende Gesellschafterin: initOS Verwaltungs GmbH

Sitz der Gesellschaft: Rosengarten – Klecken
Amtsgericht Tostedt, HRA 201840
USt-IdNr: DE 275698169
Steuer-Nr: 15/205/21402

[Philippe B (philippe-j)]

hi Jan-philipp

i'm not a dev only a "good" user
but in magento you can have an html editor for the description fields
i fond on tne web an html editor for python
http://arstechnica.com/information-technology/2009/07/how-to-build-a-desktop-wysiwyg-editor-with-webkit-and-html-5/
tinyMCE i an php java html editor
but i don't know how to implement it in openerp web interface

Philippe

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

This project is now hosted on https://github.com/OCA/connector-magento. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

966. By Jan-Philipp Fischer on 2014-06-11

Using html2text

965. By Jan-Philipp Fischer on 2014-05-04

[FIX] Copyright and pep-8 issues

964. By Jan-Philipp Fischer on 2014-03-20

[FIX] Stripping HTML Tags from Description

=== modified file 'magentoerpconnect/product.py'
--- magentoerpconnect/product.py	2014-05-26 09:37:00 +0000
+++ magentoerpconnect/product.py	2014-06-11 16:33:16 +0000
@@ -41,7 +41,11 @@
                                                   ImportMapper,
                                                   )
 from .unit.backend_adapter import GenericAdapter
+<<<<<<< TREE
 from .unit.mapper import normalize_datetime
+=======
+from .unit.mapper import strip_html
+>>>>>>> MERGE-SOURCE
 from .unit.import_synchronizer import (DelayedBatchImport,
                                        MagentoImportSynchronizer,
                                        TranslationImporter,
@@ -420,10 +424,10 @@
     _model_name = 'magento.product.product'
     # TODO :     categ, special_price => minimal_price
     direct = [('name', 'name'),
-              ('description', 'description'),
+              (strip_html('description'), 'description'),
               ('weight', 'weight'),
               ('cost', 'standard_price'),
-              ('short_description', 'description_sale'),
+              (strip_html('short_description'), 'description_sale'),
               ('sku', 'default_code'),
               ('type_id', 'product_type'),
               (normalize_datetime('created_at'), 'created_at'),

=== added file 'magentoerpconnect/unit/mapper.py'
--- magentoerpconnect/unit/mapper.py	1970-01-01 00:00:00 +0000
+++ magentoerpconnect/unit/mapper.py	2014-06-11 16:33:16 +0000
@@ -0,0 +1,28 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Jan-Philipp Fischer
+#    Copyright 2014 greencoding.de
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import html2text
+
+def strip_html(field):
+    """Strip HTML Tags from Strings"""
+    def modifier(self, record, to_attr):
+        return html2text.html2text(record[field])
+    return modifier

=== renamed file 'magentoerpconnect/unit/mapper.py' => 'magentoerpconnect/unit/mapper.py.moved'