Merge lp:~jan-philipp-fischer/openerp-connector-magento/7.0-date-bugfix into lp:~openerp-connector-core-editors/openerp-connector-magento/7.0

[Jan-Philipp Fischer]

Fixes this bug: https://bugs.launchpad.net/openerp-connector-magento/+bug/1210471

Done with the new modifier function, so newest version of openerp-connector is needed.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I'm happy to see that finally fixed, thanks!

Ideally it should be done on all date fields coming from Magento, but the rest can be done in another proposal eventually.

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Could you rename the modifier to normalize_datetime?
I think a normalize_date will be necessary as well and we have to make the distinction.

Thanks

review: Needs Fixing

[lp:~jan-philipp-fischer/openerp-connector-magento/7.0-date-bugfix]

966. By Jan-Philipp Fischer on 2014-03-19

Change Function Name

[Jan-Philipp Fischer (jan-philipp-fischer)]

Done. Please Review

review: Needs Resubmitting

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Perfect! thanks

review: Approve

[Jan-Philipp Fischer (jan-philipp-fischer)]

> I'm happy to see that finally fixed, thanks!
>
> Ideally it should be done on all date fields coming from Magento, but the rest
> can be done in another proposal eventually.

Yes think so, too. But I think this proposal should only for that reported bug.

=== modified file 'magentoerpconnect/product.py'
--- magentoerpconnect/product.py	2014-01-14 10:41:05 +0000
+++ magentoerpconnect/product.py	2014-03-19 10:56:30 +0000
@@ -41,6 +41,7 @@
                                                   ImportMapper,
                                                   )
 from .unit.backend_adapter import GenericAdapter
+from .unit.mapper import normalize_datetime
 from .unit.import_synchronizer import (DelayedBatchImport,
                                        MagentoImportSynchronizer,
                                        TranslationImporter,
@@ -395,8 +396,8 @@
               ('short_description', 'description_sale'),
               ('sku', 'default_code'),
               ('type_id', 'product_type'),
-              ('created_at', 'created_at'),
-              ('updated_at', 'updated_at'),
+              (normalize_datetime('created_at'), 'created_at'),
+              (normalize_datetime('updated_at'), 'updated_at'),
               ]
 
     @mapping

=== added file 'magentoerpconnect/unit/mapper.py'
--- magentoerpconnect/unit/mapper.py	1970-01-01 00:00:00 +0000
+++ magentoerpconnect/unit/mapper.py	2014-03-19 10:56:30 +0000
@@ -0,0 +1,31 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    Author: Guewen Baconnier
+#    Copyright 2013 Camptocamp SA
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+   
+def normalize_datetime(field):
+    """Change a invalid date which comes from Magento, if 
+    no real date is set to null for correct import to
+    OpenERP"""
+    def modifier(self, record, to_attr):
+        if record[field] == '0000-00-00 00:00:00':
+            return None
+        return record[field]
+    return modifier