Merge lp:~jan-philipp-fischer/e-commerce-addons/7.0-payment-name-required into lp:~extra-addons-commiter/e-commerce-addons/7.0

Proposed by Jan-Philipp Fischer
Status: Merged
Merged at revision: 294
Proposed branch: lp:~jan-philipp-fischer/e-commerce-addons/7.0-payment-name-required
Merge into: lp:~extra-addons-commiter/e-commerce-addons/7.0
Diff against target: 13 lines (+2/-1)
1 file modified
sale_payment_method/ (+2/-1)
To merge this branch: bzr merge lp:~jan-philipp-fischer/e-commerce-addons/7.0-payment-name-required
Reviewer Review Type Date Requested Status
S├ębastien BEAU - Approve
Csaba TOTH (community) Approve
Review via email:

Description of the change

The name field in payment_method should be required to prevent an empty data row.

To post a comment you must log in.
Revision history for this message
David BEAL (ak) (davidbeal) wrote :

seems ok for me

Revision history for this message
Csaba TOTH (tsabi) wrote :


review: Approve
Revision history for this message
S├ębastien BEAU - (sebastien.beau) wrote :


review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'sale_payment_method/'
--- sale_payment_method/ 2013-12-05 14:46:55 +0000
+++ sale_payment_method/ 2014-03-13 10:27:23 +0000
@@ -29,7 +29,8 @@
30 _columns = {30 _columns = {
31 'name': fields.char('Name',31 'name': fields.char('Name',
32 help="The name of the method on the backend"),32 help="The name of the method on the backend",
33 required=True),
33 'journal_id': fields.many2one(34 'journal_id': fields.many2one(
34 'account.journal',35 'account.journal',
35 'Journal',36 'Journal',


People subscribed via source and target branches