Merge lp:~jan-philipp-fischer/e-commerce-addons/7.0-payment-name-required into lp:~extra-addons-commiter/e-commerce-addons/7.0

Proposed by Jan-Philipp Fischer
Status: Merged
Merged at revision: 294
Proposed branch: lp:~jan-philipp-fischer/e-commerce-addons/7.0-payment-name-required
Merge into: lp:~extra-addons-commiter/e-commerce-addons/7.0
Diff against target: 13 lines (+2/-1)
1 file modified
sale_payment_method/payment_method.py (+2/-1)
To merge this branch: bzr merge lp:~jan-philipp-fischer/e-commerce-addons/7.0-payment-name-required
Reviewer Review Type Date Requested Status
S├ębastien BEAU - http://www.akretion.com Approve
Csaba TOTH (community) Approve
Review via email: mp+210768@code.launchpad.net

Description of the change

The name field in payment_method should be required to prevent an empty data row.

To post a comment you must log in.
Revision history for this message
David BEAL (ak) (davidbeal) wrote :

seems ok for me

Revision history for this message
Csaba TOTH (tsabi) wrote :

+1

review: Approve
Revision history for this message
S├ębastien BEAU - http://www.akretion.com (sebastien.beau) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'sale_payment_method/payment_method.py'
2--- sale_payment_method/payment_method.py 2013-12-05 14:46:55 +0000
3+++ sale_payment_method/payment_method.py 2014-03-13 10:27:23 +0000
4@@ -29,7 +29,8 @@
5
6 _columns = {
7 'name': fields.char('Name',
8- help="The name of the method on the backend"),
9+ help="The name of the method on the backend",
10+ required=True),
11 'journal_id': fields.many2one(
12 'account.journal',
13 'Journal',

Subscribers

People subscribed via source and target branches