MySQL Proxy

Merge lp:~jan-kneschke/mysql-proxy/routing into lp:mysql-proxy

routing
Merge into trunk

Proposed by Jan Kneschke on 2009-02-18

Status:	Merged
Merged at revision:	not available
Proposed branch:	lp:~jan-kneschke/mysql-proxy/routing
Merge into:	lp:mysql-proxy
To merge this branch:	bzr merge lp:~jan-kneschke/mysql-proxy/routing
Related bugs:	Link a bug report
Related blueprints:	expose the full network_address structure to lua (Undefined)

Reviewer	Review Type	Date Requested	Status
Kay Roepke (community)		2009-02-18	Approve on 2009-02-19
Review via email: mp+3737@code.launchpad.net

Revision history for this message

Jan Kneschke (jan-kneschke) wrote on 2009-02-18:

the major change is finishing the blueprint around network_socket and network_address

  * proxy.connection.(client|server).address is now proxy.connection.(client|server).(src|dst).*
  * changes are covered in http://jan.kneschke.de/2009/2/18/mysql-proxy-lua-classes
  * all network_socket_* functions are conforming to thier spec (returning NETWORK_SOCKET_* instead of integers)
  * the test-cases are improved for network_socket and network_address

It also contains a fix in the case of async-connect() where the NODELAY options wasn't set all the time.

Revision history for this message

Kay Roepke (kay-roepke) wrote on 2009-02-19:

looks good to me

review: Approve

lp:~jan-kneschke/mysql-proxy/routing updated on 2009-02-20

587. By <email address hidden> on 2009-02-19: replaced g_assert()s by g_return_val_if_fail() to handle them gracefully
588. By <email address hidden> on 2009-02-20: added extra checks for calling _connect() against a already setup socket
589. By <email address hidden> on 2009-02-20: added missing file to setup the mock-server for client_address.test