Merge lp:~jan-kneschke/mysql-proxy/chassis-log-domains into lp:mysql-proxy

Proposed by Jan Kneschke
Status: Merged
Merged at revision: 1154
Proposed branch: lp:~jan-kneschke/mysql-proxy/chassis-log-domains
Merge into: lp:mysql-proxy
Diff against target: 0 lines
To merge this branch: bzr merge lp:~jan-kneschke/mysql-proxy/chassis-log-domains
Reviewer Review Type Date Requested Status
Kay Roepke (community) Approve
Review via email: mp+34410@code.launchpad.net

Description of the change

a cleanup of Kay's chassis-log-domains

* the chassis-log.c and the chassis-log-extended.c are merged into one code-base
* we have domain filtering
* broadcast messages
* syslog, eventlog, stderr and file backends
* a config-file to config them

To post a comment you must log in.
Revision history for this message
Kay Roepke (kay-roepke) wrote :

The license needs updating, across pretty much every file. Probably left over from my original branch.
Should be easy with the license.pl tool.
I'm not noting this again below.

several of: implicit NULL comparison, should be NULL ==

=== modified file 'src/mysql-proxy-cli.c'
contains
+ /* the system should now be set up, let's try to log something */
+ g_message("this should go to the root logger on level message");

is this left over from debugging?

shortly afterwards:
+ g_log(NULL, CHASSIS_LOG_LEVEL_BROADCAST, "%s started", PACKAGE_STRING); /* add tag to the logfile (after we opened the logfile) */

can we come up with a short macro for broadcasts?

otherwise +1, nothing that is a deal breaker

review: Approve
1153. By <email address hidden>

added comment for _set_default

1154. By <email address hidden>

use explicit compares against NULL for pointers (coding-style)

Preview Diff

Empty

Subscribers

People subscribed via source and target branches