openWNS RISE

Merge lp:~jan-ellenbeck/openwns-rise/LTEantennaAndSpeedUp into lp:openwns-rise

  1. LTEantennaAndSpeedUp
  2. Merge into rise--main--1.0
Proposed by Jan
Status: Needs review
Proposed branch: lp:~jan-ellenbeck/openwns-rise/LTEantennaAndSpeedUp
Merge into: lp:openwns-rise
To merge this branch: bzr merge lp:~jan-ellenbeck/openwns-rise/LTEantennaAndSpeedUp
Reviewer Review Type Date Requested Status
Karsten Klagges Approve
Review via email: mp+3200@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jan (jan-ellenbeck) wrote :

- Added a 120-degree sectorized antenna according to LTE draft 3GPP 25.814
- Added two speedups for the calculation of static twodimensional antenna pattern gains that reduce simulation time in my scenarios by aobut 30%:
   1) Precomputing antenna pattern avoids wns::Ratio::from_factor() calls on runtime.
   2) Reducing angular precision from double to float and avoiding unneccesary object
      constructors/destructors saves additional computation speed when calculating the
      angle.

Reply
Revision history for this message
Karsten Klagges (karsten.klagges) wrote :

Sometimes small changes give big effects.

review: Approve
Reply

Unmerged revisions

7. By Jan

this actually works for us

6. By Jan

- Added a 120-degree sectorized antenna according to LTE draft 3GPP 25.814
- Added two speedups for the calculation of static twodimensional antenna pattern gains:
 1) Precomputing antenna pattern avoids wns::Ratio::from_factor() calls on runtime.
 2) Reducing angular precision from double to float and avoiding unneccesary object
    constructors/destructors saves additinal computation speed when calculating the
    angle.

Subscribers

People subscribed via source and target branches