lp:~jamesodhunt/upstart/fix-for-bug-912558-foo

Created by James Hunt and last modified
Get this branch:
bzr branch lp:~jamesodhunt/upstart/fix-for-bug-912558-foo
Only James Hunt can upload to this branch. If you are James Hunt please log in for upload directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
James Hunt
Project:
upstart
Status:
Development

Recent revisions

1355. By James Hunt

Temporary commit @ Thu Jan 12 10:47:18 UTC 2012

1354. By James Hunt

* init/log.c:
  - log_destroy():
    - Fixed fd leak in the case unflushed data exists but cannot be
      written.
    - Handle EBADF resulting from non-existent exec(2)'d
      command (LP: #912558)
    - Made fd check safer.
  - log_io_error_handler(): Set log->io to NULL.
  - log_file_write(): Unflushed data handling needed to consider whether
    there was any new data.
* init/tests/test_job_process.c: test_run(): Add new test
  "with single-line command running an invalid command".
* util/tests/test_user_sesions.sh:
  ensure_no_output(): Call check_job_output() and delete_job() to
  simplify logic.
  check_job_output(): New function to check for any log files.
  delete_job(): Make use of get_job_file().
  start_job(): New 'allow_failure' parameter.
  test_ensure_no_unexpected_output(): New test
  "ensure command job does not create log file with invalid command".

1353. By James Hunt

* init/man/init.5: Explain that all job processes affected
  by 'setuid' and 'setgid' stanzas.

1352. By James Hunt

* init/tests/test_job_process.c: test_run():
  - Changed timeout for test feature "ensure that no log
  file written for CONSOLE_NONE".

1351. By James Hunt

init/job_process.c: job_process_spawn():
- Set child handler to default rather than explicit ignore
  to avoid test failures in environments that disallow
  ignoring SIGCHLD.

1350. By James Hunt

* init/tests/test_job_process.c: Add missing include for
  fnmatch.h.

1349. By James Hunt

* init/man/init.5: lower-case all references to system jobs
  and user jobs.

1348. By James Hunt

* init/main.c: console_type_setter(): NihOptionSetter's should
  return 0 on success.

1347. By James Hunt

* init/log.c:
  - log_file_open(): Comments.
  - log_file_write(): Added missing cast on
    nih_io_buffer_shrink() call.

1346. By James Hunt

* init/job_process.c: job_process_spawn():
  - Correct ignoring of SIGCHLD prior to grantpt(3) call.
  - Removed redundant close(2) calls.
  - Move declarations to top of block for
    getpwnam(3)/getgrnam(3).

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
Stacked on:
lp:upstart
This branch contains Public information 
Everyone can see this information.

Subscribers