Merge lp:~jamesodhunt/upstart/bug-1240686 into lp:upstart
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 1552 | ||||
Proposed branch: | lp:~jamesodhunt/upstart/bug-1240686 | ||||
Merge into: | lp:upstart | ||||
Diff against target: |
528 lines (+170/-40) 8 files modified
ChangeLog (+21/-1) init/job_class.c (+8/-1) init/job_process.c (+2/-2) init/main.c (+8/-3) init/tests/test_main.c (+8/-8) test/test_util_common.c (+9/-5) test/test_util_common.h (+4/-3) util/tests/test_initctl.c (+110/-17) |
||||
To merge this branch: | bzr merge lp:~jamesodhunt/upstart/bug-1240686 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dimitri John Ledkov | Approve | ||
Review via email: mp+191771@code.launchpad.net |
Description of the change
* init/job_class.c:
- job_class_new(): Set umask for job to current value for Session
Init by default (LP: #1240686).
* init/job_process.c: Comments.
* init/main.c: main(): Save current umask.
* test/test_
- start_upstart_
rather than hard-coding '--no-inherit-env'.
- start_upstart(: Updated call to start_upstart_
* init/tests/
* test/test_
start_
* util/tests/
- Updated calls to start_upstart_
- test_umask(): New tests:
- "ensure Session Init inherits umask by default"
- "ensure Session Init defaults umask with '--no-inherit-env'"
No impact on re-exec since umask is retained across an exec.
lgtm.