lp:~jamesodhunt/upstart/bug-1235649
- Get this branch:
- bzr branch lp:~jamesodhunt/upstart/bug-1235649
Branch merges
- Dimitri John Ledkov: Approve
-
Diff: 817 lines (+477/-46)9 files modifiedChangeLog (+39/-8)
dbus/com.ubuntu.Upstart.xml (+4/-0)
init/control.c (+111/-18)
init/control.h (+12/-1)
init/main.c (+22/-7)
init/tests/test_control.c (+2/-2)
util/initctl.c (+53/-4)
util/man/initctl.8 (+23/-6)
util/tests/test_initctl.c (+211/-0)
Related bugs
Bug #1203595: session init, not available on dbus? | Undecided | Fix Released | |
Bug #1235649: uevent spam causes libdbus client code in session upstart to consume massive amounts of memory on Ubuntu Touch | Undecided | Fix Released |
Related blueprints
Branch information
Recent revisions
- 1547. By James Hunt
-
* dbus/com.
ubuntu. Upstart. xml: Added 'NotifyDBusAddress' method.
* init/control.c:
- control_bus_open(): Connect to the D-Bus bus specified
by control_bus_address when running as a Session Init (LP: #1203595, #1235649).
- control_disconnected( ): Display calculated bus type rather than hard-coding.
- control_handle_ bus_type( ): Removed.
- control_get_bus_ type(): Determine type of D-Bus bus that will be used.
- control_notify_ dbus_address( ): Implementation of D-Bus 'NotifyDBusAddress' method
that sets control_bus_address.
* init/main.c:
- main():
- Just check USE_SESSION_BUS_ENV variable rather than calling
control_handle_ bus_type( ).
- Don't register SIGUSR1 handler for Session Init.
- usr1_handler(): Display calculated bus type rather than hard-coding.
* init/test_control. c: Updated strings used by tests which check error
messages to include 'D-Bus'.
* util/initctl.c: Added new 'notify-dbus-address' command.
* util/man/initctl.8:
- Documentation for new 'notify-dbus-address' command.
- reset-env: Troff fix.
- Explain '--user' implicit in user mode.
* util/tests/test_initctl. c: test_dbus_ connection( ): New function providing
the following new tests:
- "ensure non-priv non-Session Init connects to D-Bus session bus on startup".
- "ensure Session Init does not connect to D-Bus session bus on startup".
- "ensure Session Init connects to D-Bus session bus when notified".
- "ensure Session Init does not connect to another bus when notified twice". - 1544. By James Hunt
-
* util/initctl.h: IS_INIT_EVENT(): Ignore session end event when
running in user mode (for 'check-config'). - 1543. By Scott James Remnant (Canonical)
-
Do not respawn jobs, that are being stopped and running pre-stop already.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:upstart