Merge lp:~jamesodhunt/upstart/bug-1188642 into lp:upstart

Proposed by James Hunt
Status: Merged
Merged at revision: 1488
Proposed branch: lp:~jamesodhunt/upstart/bug-1188642
Merge into: lp:upstart
Diff against target: 30 lines (+3/-6)
2 files modified
ChangeLog (+3/-0)
init/log.c (+0/-6)
To merge this branch: bzr merge lp:~jamesodhunt/upstart/bug-1188642
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Review via email: mp+171526@code.launchpad.net

Description of the change

* init/log.c: log_clear_unflushed(): Remove log->io assertions as the
  state cannot be reliably determined when remote_closed is set.

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ChangeLog'
2--- ChangeLog 2013-06-26 09:15:41 +0000
3+++ ChangeLog 2013-06-26 12:13:28 +0000
4@@ -10,6 +10,9 @@
5 - Comments and formatting.
6 - main(): Default to an appropriate bus.
7 - signal_filter(): Display signal details when run with --debug.
8+ * init/log.c: log_clear_unflushed(): Remove log->io assertions as the
9+ state cannot be reliably determined when remote_closed is set
10+ (LP: #1188642).
11
12 2013-06-24 James Hunt <james.hunt@ubuntu.com>
13
14
15=== modified file 'init/log.c'
16--- init/log.c 2013-05-24 14:48:33 +0000
17+++ init/log.c 2013-06-26 12:13:28 +0000
18@@ -813,12 +813,6 @@
19 * exists.
20 */
21 nih_assert (log->unflushed->len);
22-
23- /* Either the NihIo has been destroyed, or all
24- * its data has been moved to the unflushed
25- * buffer.
26- */
27- nih_assert (! log->io || ! log->io->recv_buf->len);
28 } else {
29 /* Parent job itself has ended, but job spawned one or
30 * more processes that are still running and

Subscribers

People subscribed via source and target branches