Code review comment for lp:~jamesodhunt/upstart/add-what-ident

Revision history for this message
Scott James Remnant (scott) wrote :

Out of interest, what's the use for this? Is there some script somewhere
actually expecting to be able to extract the version of the init daemon this
way instead of using "init --version" ?

On Wed, May 4, 2011 at 9:52 AM, Scott James Remnant <email address hidden>wrote:

> LGTM
>
> On Wed, May 4, 2011 at 7:19 AM, James Hunt <email address hidden>
> wrote:
>
> > James Hunt has proposed merging lp:~jamesodhunt/upstart/add-what-ident
> into
> > lp:upstart.
> >
> > Requested reviews:
> > Upstart Developers (upstart-devel)
> >
> > For more details, see:
> >
> https://code.launchpad.net/~jamesodhunt/upstart/add-what-ident/+merge/59936
> >
> > * init/main.c: Added ident to allow init daemon personality to
> > be determined the good old fashioned way: via what(1). This is
> > in line with the sysvinit package in Debian.
> >
> > --
> >
> https://code.launchpad.net/~jamesodhunt/upstart/add-what-ident/+merge/59936
> > Your team Upstart Developers is requested to review the proposed merge of
> > lp:~jamesodhunt/upstart/add-what-ident into lp:upstart.
> >
> > === modified file 'ChangeLog'
> > --- ChangeLog 2011-03-22 17:53:17 +0000
> > +++ ChangeLog 2011-05-04 14:19:22 +0000
> > @@ -1,3 +1,9 @@
> > +2011-05-04 James Hunt <email address hidden>
> > +
> > + * init/main.c: Added ident to allow init daemon personality to
> > + be determined the good old fashioned way: via what(1). This is
> > + in line with the sysvinit package in Debian.
> > +
> > 2011-03-22 Scott James Remnant <email address hidden>
> >
> > * configure.ac: Bump version to 1.3
> >
> > === modified file 'init/main.c'
> > --- init/main.c 2011-03-16 22:54:56 +0000
> > +++ init/main.c 2011-05-04 14:19:22 +0000
> > @@ -103,6 +103,8 @@
> > NIH_OPTION_LAST
> > };
> >
> > +static char ident[] __attribute__((unused)) =
> > + "@(#) " PACKAGE_NAME " " PACKAGE_VERSION;
> >
> > int
> > main (int argc,
> >
> >
> >
>
> --
> https://code.launchpad.net/~jamesodhunt/upstart/add-what-ident/+merge/59936
> Your team Upstart Developers is requested to review the proposed merge of
> lp:~jamesodhunt/upstart/add-what-ident into lp:upstart.
>

« Back to merge proposal