Merge lp:~jamesodhunt/update-manager/fix-for-bug-883618 into lp:update-manager

Proposed by James Hunt
Status: Merged
Merged at revision: 2353
Proposed branch: lp:~jamesodhunt/update-manager/fix-for-bug-883618
Merge into: lp:update-manager
Diff against target: 32 lines (+6/-2)
2 files modified
DistUpgrade/DistUpgradeQuirks.py (+2/-2)
debian/changelog (+4/-0)
To merge this branch: bzr merge lp:~jamesodhunt/update-manager/fix-for-bug-883618
Reviewer Review Type Date Requested Status
Michael Vogt Pending
Review via email: mp+96146@code.launchpad.net

Description of the change

  [ James Hunt ]
  * Only attempt to stop screensaver if DISPLAY set, and throw away
    xdg-screensaver output. (LP: #883618)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'DistUpgrade/DistUpgradeQuirks.py'
2--- DistUpgrade/DistUpgradeQuirks.py 2012-03-05 08:24:48 +0000
3+++ DistUpgrade/DistUpgradeQuirks.py 2012-03-06 15:17:20 +0000
4@@ -816,11 +816,11 @@
5 logging.debug("killing gnome-screensaver")
6 subprocess.call(["killall", "-q", "gnome-screensaver"])
7 def _pokeScreensaver(self):
8- if os.path.exists("/usr/bin/xdg-screensaver"):
9+ if os.path.exists("/usr/bin/xdg-screensaver") and os.environ.get('DISPLAY') :
10 logging.debug("setup poke timer for the scrensaver")
11 try:
12 self._poke = subprocess.Popen(
13- "while true; do /usr/bin/xdg-screensaver reset; sleep 30; done",
14+ "while true; do /usr/bin/xdg-screensaver reset >/dev/null 2>&1; sleep 30; done",
15 shell=True)
16 atexit.register(self._stopPokeScreensaver)
17 except:
18
19=== modified file 'debian/changelog'
20--- debian/changelog 2012-03-05 08:24:48 +0000
21+++ debian/changelog 2012-03-06 15:17:20 +0000
22@@ -14,6 +14,10 @@
23 * Improve the warning issued when i8xx graphics hardware is
24 detected. (LP: #941172)
25
26+ [ James Hunt ]
27+ * Only attempt to stop screensaver if DISPLAY set, and throw away
28+ xdg-screensaver output. (LP: #883618)
29+
30 -- Michael Vogt <michael.vogt@ubuntu.com> Mon, 05 Mar 2012 09:15:40 +0100
31
32 update-manager (1:0.156.7) precise; urgency=low

Subscribers

People subscribed via source and target branches

to status/vote changes: