lp:~jamesodhunt/ubuntu/vivid/ubuntu-core-upgrader/handle-invalid-removed-file

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntu/vivid/ubuntu-core-upgrader at revision 24

Michael Vogt (community): Needs Information on 2015-04-09

Diff: 406 lines (+157/-56)

5 files modified

debian/changelog (+9/-0)
functional/test_upgrader.py (+78/-20)
ubuntucoreupgrader/tests/test_upgrader.py (+46/-10)
ubuntucoreupgrader/tests/utils.py (+6/-3)
ubuntucoreupgrader/upgrader.py (+18/-23)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1437225: system-image should not generate an empty 'removed' file

Undecided

New

Link a bug report

Related blueprints

26. By James Hunt on 2015-04-08

* Review changes.

25. By James Hunt on 2015-04-07

* functional/test_upgrader.py:
  - call_upgrader(): Set created objects cache_dir to the root_dir to
    allow the caller to check for deletion.
  - Updated tests which remove files to pass in correct root dir to
    upgrader.
  - test_remove_file(): Fixed incorrect assertion.
* ubuntucoreupgrader/tests/test_upgrader.py:
  - test_empty_removed_file(): New test.
* ubuntucoreupgrader/tests/utils.py:
  - add_to_removed_file(): Call os.path.normpath().
  - setUp(): Create system sub-dir to simplify creating files the
    upgrader can manipulate.
* ubuntucoreupgrader/upgrader.py:
  - Only call get_cache_dir() once in constructor. This saves needless
    calls and makes testing easier.
  - _cmd_update(): Use a single code path regardless of the specified
    root to ensure the tests mirror the real upgrader logic.

24. By James Hunt on 2015-03-27

functional/test_upgrader.py: Add tests for an invalid removed file.

23. By James Hunt on 2015-03-27

ubuntucoreupgrader/upgrader.py: Tolerate an invalid 'removed' file
to avoid the upgrade failing attempting to remove '/writable/cache'
(see LP: #1437225).

22. By Michael Vogt on 2015-03-13

releasing package ubuntu-core-upgrader version 0.7.7

21. By Michael Vogt on 2015-03-13

fix entry point for s-i 3.0

20. By Michael Vogt on 2015-03-10

releasing package ubuntu-core-upgrader version 0.7.6

19. By Michael Vogt on 2015-03-10

merged lp:~mvo/ubuntu/vivid/ubuntu-core-upgrader/chainsaw-removal

18. By Michael Vogt on 2015-03-04

merged lp:~jamesodhunt/ubuntu/vivid/ubuntu-core-upgrader/add-functional-tests

17. By Michael Vogt on 2015-03-04

releasing package ubuntu-core-upgrader version 0.7.5