Merge lp:~jamesodhunt/ubuntu/utopic/multipath-tools/document-sync-option into lp:ubuntu/utopic/multipath-tools

Proposed by James Hunt
Status: Needs review
Proposed branch: lp:~jamesodhunt/ubuntu/utopic/multipath-tools/document-sync-option
Merge into: lp:ubuntu/utopic/multipath-tools
Diff against target: 166 lines (+111/-1)
6 files modified
.pc/0015-kpartx-options-manpage.patch/kpartx/kpartx.8 (+65/-0)
.pc/applied-patches (+1/-0)
debian/changelog (+6/-0)
debian/patches/0015-kpartx-options-manpage.patch (+30/-0)
debian/patches/series (+1/-0)
kpartx/kpartx.8 (+8/-1)
To merge this branch: bzr merge lp:~jamesodhunt/ubuntu/utopic/multipath-tools/document-sync-option
Reviewer Review Type Date Requested Status
Marc Deslauriers Needs Fixing
Review via email: mp+230648@code.launchpad.net

Description of the change

* debian/patches/0011-kpartx-options-manpage.patch: Document '-s' option.

To post a comment you must log in.
51. By Rafael David Tinoco

* Added 0011-libmultipath-update-waiter-handling.patch (LP: #1354114)
* Added 0012-Race-condition-when-calling-stop_waiter_thread.patch (LP: #1354114)
* Added 0013-multipath-clean-up-code-for-stopping-the-waiter-thre.patch (LP: #1354114)
* Added 0014-Fix-race-condition-in-stop_waiter_thread.patch (LP: #1354114)

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

This doesn't look right. I don't see the actual patch in the commit. Perhaps forgot to bzr add it?

review: Needs Fixing
52. By James Hunt

debian/patches/0011-kpartx-options-manpage.patch: document '-s' option.

Revision history for this message
James Hunt (jamesodhunt) wrote :

Thanks Marc - branch updated.

Unmerged revisions

52. By James Hunt

debian/patches/0011-kpartx-options-manpage.patch: document '-s' option.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory '.pc/0015-kpartx-options-manpage.patch'
2=== added file '.pc/0015-kpartx-options-manpage.patch/.timestamp'
3=== added directory '.pc/0015-kpartx-options-manpage.patch/kpartx'
4=== added file '.pc/0015-kpartx-options-manpage.patch/kpartx/kpartx.8'
5--- .pc/0015-kpartx-options-manpage.patch/kpartx/kpartx.8 1970-01-01 00:00:00 +0000
6+++ .pc/0015-kpartx-options-manpage.patch/kpartx/kpartx.8 2014-09-29 10:17:02 +0000
7@@ -0,0 +1,65 @@
8+.TH KPARTX 8 "July 2006" "" "Linux Administrator's Manual"
9+.SH NAME
10+kpartx \- Create device maps from partition tables
11+.SH SYNOPSIS
12+.B kpartx
13+.RB [\| \-a\ \c
14+.BR |\ -d\ |\ -l \|]
15+.RB [\| \-v \|]
16+.RB wholedisk
17+.SH DESCRIPTION
18+This tool, derived from util-linux' partx, reads partition
19+tables on specified device and create device maps over partitions
20+segments detected. It is called from hotplug upon device maps
21+creation and deletion.
22+.SH OPTIONS
23+.TP
24+.B \-a
25+Add partition mappings
26+.TP
27+.B \-r
28+Read-only partition mappings
29+.TP
30+.B \-d
31+Delete partition mappings
32+.TP
33+.B \-l
34+List partition mappings that would be added \-a
35+.TP
36+.B \-p
37+set device name-partition number delimiter
38+.TP
39+.B \-g
40+force GUID partition table (GPT)
41+.TP
42+.B \-v
43+Operate verbosely
44+.SH EXAMPLE
45+To mount all the partitions in a raw disk image:
46+.IP
47+kpartx -av disk.img
48+.PP
49+This will output lines such as:
50+.IP
51+loop3p1 : 0 20964762 /dev/loop3 63
52+.PP
53+The
54+.I loop3p1
55+is the name of a device file under
56+.I /dev/mapper
57+which you can use to access the partition, for example to fsck it:
58+.IP
59+fsck /dev/mapper/loop3p1
60+.PP
61+When you're done, you need to remove the devices:
62+.IP
63+kpartx -d disk.img
64+.SH "SEE ALSO"
65+.BR multipath (8)
66+.BR multipathd (8)
67+.BR hotplug (8)
68+.SH "AUTHORS"
69+This man page was assembled By Patrick Caulfield
70+for the Debian project. From documentation provided
71+by the multipath author Christophe Varoqui, <christophe.varoqui@opensvc.com> and others.
72+
73
74=== modified file '.pc/applied-patches'
75--- .pc/applied-patches 2014-09-02 15:43:38 +0000
76+++ .pc/applied-patches 2014-09-29 10:17:02 +0000
77@@ -14,3 +14,4 @@
78 0012-Race-condition-when-calling-stop_waiter_thread.patch
79 0013-multipath-clean-up-code-for-stopping-the-waiter-thre.patch
80 0014-Fix-race-condition-in-stop_waiter_thread.patch
81+0015-kpartx-options-manpage.patch
82
83=== modified file 'debian/changelog'
84--- debian/changelog 2014-09-02 15:43:38 +0000
85+++ debian/changelog 2014-09-29 10:17:02 +0000
86@@ -1,3 +1,9 @@
87+multipath-tools (0.4.9-3ubuntu10) UNRELEASED; urgency=medium
88+
89+ * debian/patches/0011-kpartx-options-manpage.patch: document '-s' option.
90+
91+ -- James Hunt <james.hunt@ubuntu.com> Mon, 29 Sep 2014 11:15:46 +0100
92+
93 multipath-tools (0.4.9-3ubuntu9) utopic; urgency=medium
94
95 * Added 0011-libmultipath-update-waiter-handling.patch (LP: #1354114)
96
97=== added file 'debian/patches/0015-kpartx-options-manpage.patch'
98--- debian/patches/0015-kpartx-options-manpage.patch 1970-01-01 00:00:00 +0000
99+++ debian/patches/0015-kpartx-options-manpage.patch 2014-09-29 10:17:02 +0000
100@@ -0,0 +1,30 @@
101+Description: Add missing '-s' option and warn about running asynchronously.
102+Author: James Hunt <james.hunt@ubuntu.com>
103+Last-Update: 2014-08-13
104+---
105+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
106+--- a/kpartx/kpartx.8
107++++ b/kpartx/kpartx.8
108+@@ -15,7 +15,10 @@
109+ .SH OPTIONS
110+ .TP
111+ .B \-a
112+-Add partition mappings
113++Add partition mappings, asynchronously by default.
114++
115++Note that unless \fB\-s\fR is also specified, mappings may not be fully
116++available when kpartx exits\fR.
117+ .TP
118+ .B \-r
119+ Read-only partition mappings
120+@@ -32,6 +35,10 @@
121+ .B \-g
122+ force GUID partition table (GPT)
123+ .TP
124++.B \-s
125++Operate synchronously - block until the operation has completed. Only
126++meaningful when used with \fB\-a\fR.
127++.TP
128+ .B \-v
129+ Operate verbosely
130+ .SH EXAMPLE
131
132=== modified file 'debian/patches/series'
133--- debian/patches/series 2014-09-02 15:43:38 +0000
134+++ debian/patches/series 2014-09-29 10:17:02 +0000
135@@ -14,3 +14,4 @@
136 0012-Race-condition-when-calling-stop_waiter_thread.patch
137 0013-multipath-clean-up-code-for-stopping-the-waiter-thre.patch
138 0014-Fix-race-condition-in-stop_waiter_thread.patch
139+0015-kpartx-options-manpage.patch
140
141=== modified file 'kpartx/kpartx.8'
142--- kpartx/kpartx.8 2011-12-04 21:32:48 +0000
143+++ kpartx/kpartx.8 2014-09-29 10:17:02 +0000
144@@ -15,7 +15,10 @@
145 .SH OPTIONS
146 .TP
147 .B \-a
148-Add partition mappings
149+Add partition mappings, asynchronously by default.
150+
151+Note that unless \fB\-s\fR is also specified, mappings may not be fully
152+available when kpartx exits\fR.
153 .TP
154 .B \-r
155 Read-only partition mappings
156@@ -32,6 +35,10 @@
157 .B \-g
158 force GUID partition table (GPT)
159 .TP
160+.B \-s
161+Operate synchronously - block until the operation has completed. Only
162+meaningful when used with \fB\-a\fR.
163+.TP
164 .B \-v
165 Operate verbosely
166 .SH EXAMPLE

Subscribers

People subscribed via source and target branches

to all changes: