Merge lp:~jamesodhunt/ubuntu/precise/upstart/bug-974147 into lp:ubuntu/precise/upstart
|Diff against target:||53 lines (+21/-0) 2 files modified|
|To merge this branch:||bzr merge lp:~jamesodhunt/ubuntu/precise/upstart/bug-974147|
|Related bugs and blueprints:||
Description of the Change
debian/upstart-job: Do not start or restart disabled jobs (LP: #974147)
I'm not 100% happy with the restart case, hence my big comment in debian/upstart-job, but I think it's the best we can do. That said, simply calling "exit 0" would be the path of least surprise for users if the job is disabled but is found to be running. Maybe a compromise might be to go with my logic, but add a warning along the lines of:
WARNING: reload command stopped disabled job '$JOB', but will NOT restart it.
- 1390. By James Hunt on 2012-04-16
* debian/upstart-job: Add in handling for disabled jobs:
- Do not restart a job if disabled, unless job was forcibly started.
- Do stop a disabled job that was forcibly started.
Resolves issue where 'invoke-rc.d restart' erroneously started disabled
jobs on package upgrade (LP: #974147)