Merge lp:~jamesodhunt/ubuntu/precise/upstart/bug-935585 into lp:ubuntu/precise/upstart

Proposed by James Hunt
Status: Merged
Merged at revision: 1376
Proposed branch: lp:~jamesodhunt/ubuntu/precise/upstart/bug-935585
Merge into: lp:ubuntu/precise/upstart
Diff against target: 45 lines (+18/-2)
2 files modified
debian/changelog (+7/-2)
init/log.c (+11/-0)
To merge this branch: bzr merge lp:~jamesodhunt/ubuntu/precise/upstart/bug-935585
Reviewer Review Type Date Requested Status
Stéphane Graber Pending
Review via email: mp+97937@code.launchpad.net

Description of the change

  [ Steve Langasek ]
  * debian/conf/failsafe.conf: instead of waiting for the 'runlevel' event
    before considering failsafe done, stop this job as soon as we're
    starting rc-sysinit; that way, any delays in /etc/rcS.d will not cause
    confusing messages about networking delays when the network is not the
    problem. LP: #950662.

  [ James Hunt ]
  * init/log.c:log_read_watch(): Set remote_closed for scenarios where error
     handler never called (LP: #935585).

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-03-09 19:43:20 +0000
3+++ debian/changelog 2012-03-16 17:35:29 +0000
4@@ -1,12 +1,17 @@
5-upstart (1.4-0ubuntu9) UNRELEASED; urgency=low
6+upstart (1.4-0ubuntu9) precise; urgency=low
7
8+ [ Steve Langasek ]
9 * debian/conf/failsafe.conf: instead of waiting for the 'runlevel' event
10 before considering failsafe done, stop this job as soon as we're
11 starting rc-sysinit; that way, any delays in /etc/rcS.d will not cause
12 confusing messages about networking delays when the network is not the
13 problem. LP: #950662.
14
15- -- Steve Langasek <steve.langasek@ubuntu.com> Fri, 09 Mar 2012 11:41:55 -0800
16+ [ James Hunt ]
17+ * init/log.c:log_read_watch(): Set remote_closed for scenarios where error
18+ handler never called (LP: #935585).
19+
20+ -- James Hunt <james.hunt@ubuntu.com> Fri, 16 Mar 2012 17:20:11 +0000
21
22 upstart (1.4-0ubuntu8) precise; urgency=low
23
24
25=== modified file 'init/log.c'
26--- init/log.c 2012-02-14 16:56:51 +0000
27+++ init/log.c 2012-03-16 17:35:29 +0000
28@@ -685,6 +685,17 @@
29 break;
30 }
31 }
32+
33+ /* Job process has ended and we've drained all the data the job
34+ * produced, so remote end must have closed.
35+ *
36+ * This cannot be handled entirely by log_io_error_handler()
37+ * since the job may produce some output prior to disks being
38+ * writeable, then end without producing further output.
39+ * In this scenario the error handler is never called.
40+ *
41+ */
42+ log->remote_closed = 1;
43 }
44
45 /**

Subscribers

People subscribed via source and target branches

to all changes: