Merge lp:~jamesodhunt/ubuntu/precise/procps/fix-for-bug-771372 into lp:ubuntu/precise/procps
Proposed by
James Hunt
Status: | Merged |
---|---|
Merge reported by: | Steve Langasek |
Merged at revision: | not available |
Proposed branch: | lp:~jamesodhunt/ubuntu/precise/procps/fix-for-bug-771372 |
Merge into: | lp:ubuntu/precise/procps |
Diff against target: |
31 lines (+12/-1) 2 files modified
debian/changelog (+9/-0) debian/upstart (+3/-1) |
To merge this branch: | bzr merge lp:~jamesodhunt/ubuntu/precise/procps/fix-for-bug-771372 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Langasek | Pending | ||
Ubuntu branches | Pending | ||
Review via email: mp+82412@code.launchpad.net |
This proposal supersedes a proposal from 2011-11-11.
Description of the change
message:
Make procps job run twice: as early as possible (for kernel
parameters such as kernel.printk) and then afteer all network
interfaces are up (to account for any kernel parameters relating
to recently loaded networking modules) (LP: #771372).
modified:
debian/changelog
debian/upstart
To post a comment you must log in.
There are a couple of race conditions here that have me hesitant to merge this particular implementation because I'm worried it isn't going to do the job.
The first race condition is that sysctl might take a long time to complete, so the first 'start on virtual- filesystems' job could still be running at the time 'started networking' is emitted, causing the job to only be run once. I think this is an unlikely race condition for us to hit in practice, so it doesn't really worry me, given that everyone acknowledges that this script is still very kludgy.
The second race condition, however, is one that I know we hit in practice: /etc/init/ networking. conf may trigger before all of the network devices are actually available. If we miss *this* race with one of the devices we're attempting to apply sysctl settings to, we're in trouble.
James, what do you think about either changing this to be 'start on [...] or static-network-up', or changing it to be 'start on [...] or net-device-up' with an 'instance' rule?