Merge lp:~jamesodhunt/ubuntu/natty/portmap/add-missing-emits-stanza into lp:ubuntu/natty/portmap

Proposed by James Hunt
Status: Merged
Merged at revision: 23
Proposed branch: lp:~jamesodhunt/ubuntu/natty/portmap/add-missing-emits-stanza
Merge into: lp:ubuntu/natty/portmap
Diff against target: 27 lines (+9/-0)
2 files modified
debian/changelog (+7/-0)
debian/portmap.portmap-boot.upstart (+2/-0)
To merge this branch: bzr merge lp:~jamesodhunt/ubuntu/natty/portmap/add-missing-emits-stanza
Reviewer Review Type Date Requested Status
Dave Walker (community) Approve
Ubuntu branches Pending
Review via email: mp+53211@code.launchpad.net

Description of the change

* debian/portmap.portmap-boot.upstart: Added "emits" stanza to stop this
  package breaking "initctl check-config" (LP: #734736).

To post a comment you must log in.
Revision history for this message
Dave Walker (davewalker) wrote :

Good catch!

Is this documented anywhere to stop it happening again in the future?

Thanks.

review: Approve
Revision history for this message
James Hunt (jamesodhunt) wrote :

Hi Dave - "man 5 init" does now document this new behaviour. Users can choose to ignore it if they don't wish to make use of check-config, but we should review all our .conf files for compliance.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-03-02 13:52:18 +0000
3+++ debian/changelog 2011-03-14 09:56:36 +0000
4@@ -1,3 +1,10 @@
5+portmap (6.0.0-2ubuntu5) natty; urgency=low
6+
7+ * debian/portmap.portmap-boot.upstart: Added "emits" stanza to stop this
8+ package breaking "initctl check-config" (LP: #734736).
9+
10+ -- James Hunt <james.hunt@ubuntu.com> Mon, 14 Mar 2011 09:51:33 +0000
11+
12 portmap (6.0.0-2ubuntu4) natty; urgency=low
13
14 [ Steve Langasek ]
15
16=== modified file 'debian/portmap.portmap-boot.upstart'
17--- debian/portmap.portmap-boot.upstart 2011-01-10 18:21:26 +0000
18+++ debian/portmap.portmap-boot.upstart 2011-03-14 09:56:36 +0000
19@@ -3,6 +3,8 @@
20 description "Upstart job to start portmap on boot only"
21 author "Clint Byrum"
22
23+emits start-portmap
24+
25 start on virtual-filesystems and net-device-up IFACE=lo
26
27 task

Subscribers

People subscribed via source and target branches

to all changes: