Snappy

Merge lp:~jamesodhunt/snappy/set-lang-for-coverage-reports into lp:~snappy-dev/snappy/snappy-moved-to-github

  1. set-lang-for-coverage-reports
  2. Merge into snappy-moved-to-github
Proposed by James Hunt
Status: Rejected
Rejected by: James Hunt
Proposed branch: lp:~jamesodhunt/snappy/set-lang-for-coverage-reports
Merge into: lp:~snappy-dev/snappy/snappy-moved-to-github
Diff against target: 11 lines (+2/-0)
1 file modified
gen-coverage.sh (+2/-0)
To merge this branch: bzr merge lp:~jamesodhunt/snappy/set-lang-for-coverage-reports
Reviewer Review Type Date Requested Status
Sergio Schvezov Needs Information
Review via email: mp+254430@code.launchpad.net

Description of the change

Same issue as fixed on https://code.launchpad.net/~jamesodhunt/snappy/ensure-locale-is-c-for-tests/+merge/254379:

* Set LANG=C to avoid failures.

To post a comment you must log in.
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

This shouldn't be needed anymore with mvo's latest branch, right?

review: Needs Information
Revision history for this message
James Hunt (jamesodhunt) wrote :

Yep - now redundant.

Unmerged revisions

272. By James Hunt

* Set LANG=C to avoid failures.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gen-coverage.sh'
2--- gen-coverage.sh 2015-03-25 10:40:59 +0000
3+++ gen-coverage.sh 2015-03-27 17:04:02 +0000
4@@ -2,6 +2,8 @@
5
6 set -e
7
8+LANG=C
9+
10 go get github.com/axw/gocov/gocov
11 go get gopkg.in/matm/v1/gocov-html
12

Subscribers

People subscribed via source and target branches