Code review comment for lp:~jamesodhunt/libnih/fix-for-bug-834813

Revision history for this message
Scott James Remnant (scott) wrote :

"str && *str" shouldn't be necessary, this function already asserts "str != NULL"

Have you checked other uses of strchr() in the code, I probably make the same mistake all over the place - believing it would return NULL if given '\0'

I'd like that final if() cleaned up, it doesn't make sense what you're doing there - perhaps splitting out some informationally named temporary variables and checking those would make more sense, or using some other method

review: Needs Fixing

« Back to merge proposal