Merge lp:~jamesh/unity-api/remove-boost-dep into lp:unity-api

[James Henstridge]

Remove unnecessary Boost dependency from package.

Remove unnecessary Boost dependency from package: while the CMakeLists.txt checks for Boost regex, I can see no source or header files including a Boost header.

[Unity8 CI Bot (unity8-ci-bot)]

PASSED: Continuous integration, rev:241
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/93/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2432
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2460
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2347
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2347
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2347
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2340
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2340/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2340
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2340/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2340
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2340/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2340
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2340/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2340
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2340/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2340
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2340/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2340
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2340/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2340
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2340/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2340
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2340/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity-api-ci/93/rebuild

review: Approve (continuous-integration)

[Michi Henning (michihenning)]

Looks good to me.

review: Approve

[Michi Henning (michihenning)]

Thanks for that! A zero-warning build policy would be good, as would be adding -Werror for release builds.

review: Approve

[James Henstridge (jamesh)]

Backed out second revision, because the fix was included in the latest unity-api landing.

=== modified file 'CMakeLists.txt'
--- CMakeLists.txt	2016-03-14 08:12:08 +0000
+++ CMakeLists.txt	2016-08-05 04:04:23 +0000
@@ -79,7 +79,6 @@
 
 
 include(FindPkgConfig)
-find_package(Boost 1.49.0 COMPONENTS regex REQUIRED)
 pkg_check_modules(GLIB glib-2.0 REQUIRED)
 
 # Standard install paths

=== modified file 'debian/control'
--- debian/control	2015-11-18 12:30:41 +0000
+++ debian/control	2016-08-05 04:04:23 +0000
@@ -12,8 +12,6 @@
 # on an x86 CPU for example, when cross-compiling.
                g++:native,
                graphviz,
-               libboost-dev (>= 1.49),
-               libboost-regex-dev (>= 1.49),
                libglib2.0-dev,
                libgtest-dev,
                pkg-config,
@@ -45,8 +43,7 @@
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libboost-dev (>= 1.49),
-         libunity-api0 (= ${binary:Version}),
+Depends: libunity-api0 (= ${binary:Version}),
          ${misc:Depends},
 Description: Header files for Unity API
  Library to integrate with the Unity shell (dev files)