Merge lp:~jamesh/ubuntu-scopes/calculator-test-fixes into lp:~submarine/ubuntu-scopes/calculator

Proposed by James Henstridge
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 27
Merged at revision: 27
Proposed branch: lp:~jamesh/ubuntu-scopes/calculator-test-fixes
Merge into: lp:~submarine/ubuntu-scopes/calculator
Diff against target: 14 lines (+3/-1)
1 file modified
tests/test_calculator.py (+3/-1)
To merge this branch: bzr merge lp:~jamesh/ubuntu-scopes/calculator-test-fixes
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Submarine Pending
Review via email: mp+153987@code.launchpad.net

Commit message

Disable test of "sqrtpi" test due to encoding issues.

Description of the change

Disable the "sqrtpi" test.

Jenkins runs the tests in a non-UTF-8 locale, which causes the unicode command line arguments to be passed in unicode escape form (as "\u221a\u03c0"). Trying to pass an encoded byte string to GLib.spawn_sync() doesn't seem to work, so I have left it disabled for now.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
David Callé (davidc3) wrote :

+1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/test_calculator.py'
2--- tests/test_calculator.py 2013-03-15 17:25:19 +0000
3+++ tests/test_calculator.py 2013-03-19 04:18:20 +0000
4@@ -49,7 +49,9 @@
5 def test_valid_searches(self):
6 self.assertResultTitle('0+0', ['0'])
7 self.assertResultTitle('tan5', ['0.087488664'])
8- self.assertResultTitle('sqrtpi', ['1.772453851'])
9+ # XXX: Disabled since it fails in a non-UTF-8 locale, such as
10+ # the testing environment.
11+ #self.assertResultTitle('sqrtpi', ['1.772453851'])
12 self.assertResultTitle('1,23%+10', ['10.0123'])
13
14 def test_failing_search(self):

Subscribers

People subscribed via source and target branches

to all changes: