Merge lp:~jamesh/thumbnailer/use-thumbnailer-interface into lp:thumbnailer/devel

Proposed by James Henstridge on 2017-02-20
Status: Merged
Approved by: Michi Henning on 2017-03-07
Approved revision: 374
Merged at revision: 375
Proposed branch: lp:~jamesh/thumbnailer/use-thumbnailer-interface
Merge into: lp:thumbnailer/devel
Diff against target: 39 lines (+2/-11)
1 file modified
snap/snapcraft.yaml (+2/-11)
To merge this branch: bzr merge lp:~jamesh/thumbnailer/use-thumbnailer-interface
Reviewer Review Type Date Requested Status
Michi Henning (community) 2017-02-20 Approve on 2017-03-07
unity-api-1-bot continuous-integration Approve on 2017-02-20
Review via email: mp+317744@code.launchpad.net

Commit message

Switch to the specialised "thumbnailer" snapd interface.

Description of the change

Switch to the specialised "thumbnailer" snapd interface.

I also moved snapcraft.yaml to snap/snapcraft.yaml, which seems to be the preferred location now. You should still run "snapcraft" at the root of the branch.

This interface is only available in the upcoming snapd 2.23, which will hopefully be released soon. It might be worth delaying merging this until it is out.

To post a comment you must log in.
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:374
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/37/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1697
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1704
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1479/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1479/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1479/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1479/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1479/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1479
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1479/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/37/rebuild

review: Approve (continuous-integration)
Michi Henning (michihenning) wrote :

Interface has merged into snapd now, so all good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'snap'
2=== renamed file 'snapcraft.yaml' => 'snap/snapcraft.yaml'
3--- snapcraft.yaml 2017-02-08 06:54:23 +0000
4+++ snap/snapcraft.yaml 2017-02-20 07:29:38 +0000
5@@ -11,9 +11,7 @@
6
7 slots:
8 thumbnailer:
9- interface: dbus
10- name: com.canonical.Thumbnailer
11- bus: session
12+ interface: thumbnailer
13
14 plugs:
15 platform:
16@@ -21,12 +19,8 @@
17 content: ubuntu-app-platform1
18 target: ubuntu-app-platform
19 default-provider: ubuntu-app-platform
20- network-manager:
21- interface: network-manager
22 thumbnails:
23- interface: dbus
24- name: com.canonical.Thumbnailer
25- bus: session
26+ interface: thumbnailer
27
28 apps:
29 thumbnailer-service:
30@@ -37,9 +31,6 @@
31 plugs:
32 - platform
33 - network
34- # TODO: This grants more privileges than we really need but, without this, apparmor
35- # denies access.
36- - network-manager
37 # TODO: The gsettings interface currently does not permit reading.
38 # See https://bugs.launchpad.net/snappy/+bug/1600154
39 # For now, the service uses default settings because it's gsettings lookups fail.

Subscribers

People subscribed via source and target branches

to all changes: