Merge lp:~jamesh/thumbnailer/snap-gettext-dep into lp:thumbnailer/devel

Proposed by James Henstridge on 2017-03-13
Status: Merged
Approved by: James Henstridge on 2017-03-13
Approved revision: 376
Merged at revision: 376
Proposed branch: lp:~jamesh/thumbnailer/snap-gettext-dep
Merge into: lp:thumbnailer/devel
Diff against target: 11 lines (+1/-0)
1 file modified
snap/snapcraft.yaml (+1/-0)
To merge this branch: bzr merge lp:~jamesh/thumbnailer/snap-gettext-dep
Reviewer Review Type Date Requested Status
unity-api-1-bot continuous-integration Approve on 2017-03-13
Unity Team 2017-03-13 Pending
Review via email: mp+319664@code.launchpad.net

Commit message

Add gettext as a dependency for the snap build.

Description of the change

Add gettext as a dependency for the snap build.

The new version of the GSettings macro from cmake-extras requires gettext for some reason, so add it as a dependency.

To post a comment you must log in.
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:376
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/39/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1773
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1780
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1556
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1556/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1556
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1556/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1556
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1556/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1556
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1556/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1556
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1556/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1556
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1556/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-thumbnailer-ci/39/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'snap/snapcraft.yaml'
2--- snap/snapcraft.yaml 2017-03-07 06:41:49 +0000
3+++ snap/snapcraft.yaml 2017-03-13 04:34:31 +0000
4@@ -87,6 +87,7 @@
5 build-packages:
6 - cmake
7 - cmake-extras
8+ - gettext
9 - google-mock
10 - gstreamer1.0-libav # For H.264
11 - libapparmor-dev

Subscribers

People subscribed via source and target branches

to all changes: