Code review comment for lp:~jamesh/thumbnailer/no-fallback-albumart

Revision history for this message
Michi Henning (michihenning) wrote :

Disappearing fallback images? How? How can I reproduce?

Seeing that you set the commit message, I take that this is good to go for the time being?

I'm happy with what is there now. I suggest that we merge to devel, but hold off with the silo until after OTA-9. That'll give us time to sort out what's going with the disappearing fallback images, and also give us time for more testing, seeing that lots of other components are affected by this change. (A few hours ago, there were still comments flying past regarding fallback images in the dash, for example.)

If you agree, please top-approve yourself.

review: Approve

« Back to merge proposal