Code review comment for lp:~jamesh/thumbnailer/no-fallback-albumart

Revision history for this message
Michi Henning (michihenning) wrote :

Looks good to me. A few minor quibbles:

In thumbnailerimageresponse.cpp, there is a stale comment in textureFactory().

The test writes to ~/.cache/unity-thumbnailer. It would be good to write to a different cache dir. (Setting XDG_CACHE_HOME for the test should take care of it.)

In Fixture.qml. line 113:

return Qt.rgba(data[pos] / 255, data[pos+1] / 255, data[pos+2] / 255, data[pos+3] / 255);

Might this be behind the failure on big-ending machines?

review: Needs Fixing

« Back to merge proposal