Merge lp:~jamesh/storm/bug-697513 into lp:storm
Proposed by
James Henstridge
Status: | Merged |
---|---|
Approved by: | Jamu Kakar |
Approved revision: | 385 |
Merged at revision: | 385 |
Proposed branch: | lp:~jamesh/storm/bug-697513 |
Merge into: | lp:storm |
Diff against target: | 0 lines |
To merge this branch: | bzr merge lp:~jamesh/storm/bug-697513 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jamu Kakar (community) | Approve | ||
Gustavo Niemeyer | Approve | ||
Review via email: mp+45221@code.launchpad.net |
Description of the change
Currently if there is a live but invalidated object for Store.get()'s return value, Storm will issue a query to make sure the object still exists in the database, but doesn't load any data from the database. When the object is inevitably accessed, another query is issued to get the field values.
I don't think this makes sense, so this branch changes it to retrieve the full object.
To post a comment you must log in.
This looks correct to me, and like a good optimization. +1