lp:~jamesh/mediascanner2/taglib-extractor

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:mediascanner2 at revision 322

Michi Henning (community): Approve on 2016-02-26

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2016-02-16

Diff: 1670 lines (+1034/-409)

15 files modified

CMakeLists.txt (+1/-0)
HACKING (+22/-0)
debian/control (+1/-0)
debian/control.in (+1/-0)
src/extractor/CMakeLists.txt (+5/-1)
src/extractor/ExtractorBackend.cc (+15/-340)
src/extractor/GStreamerExtractor.cc (+178/-0)
src/extractor/GStreamerExtractor.hh (+48/-0)
src/extractor/ImageExtractor.cc (+241/-0)
src/extractor/ImageExtractor.hh (+47/-0)
src/extractor/TaglibExtractor.cc (+295/-0)
src/extractor/TaglibExtractor.hh (+42/-0)
test/CMakeLists.txt (+1/-1)
test/test_extractorbackend.cc (+137/-1)
test/test_metadataextractor.cc (+0/-66)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1536832: /usr/bin/mediascanner-service-2.0:6:__gnu_cxx::__verbose_terminate_handler:__cxxabiv1::__terminate:std::terminate:__cxxabiv1::__cxa_throw:std::__throw_logic_error

Undecided

Fix Released

Link a bug report

Related blueprints

332. By James Henstridge on 2016-02-24

For FLAC files, set hasThumbnail to true if pictureList() is not empty.

331. By James Henstridge on 2016-02-24

Protect against GValues holding NULL strings.

330. By James Henstridge on 2016-02-24

Add isValid() checks to taglib extractor code paths.

329. By James Henstridge on 2016-02-17

Add a hacking file that notes the need to install the qt5-default
package.

328. By James Henstridge on 2016-02-16

Add missing break statement.

327. By James Henstridge on 2016-02-16

Add some file format specific tests to test_extractorbackend.cc

326. By James Henstridge on 2016-02-16

Fix up date parsing for MP3 and MP4, to ensure we get the month and day.

Run mp3/mp4 tests in test_metadataextractor unconditionally, since they
don't depend on codecs anymore.

Add TagLib vs. GStreamer tests for MP3 and MP4 to test_extractorbackend.

325. By James Henstridge on 2016-02-12

build-depend on libtag1-dev.

324. By James Henstridge on 2016-02-12

Add a test to compre GStreamer and Taglib based extraction of a vorbis file.

323. By James Henstridge on 2016-02-11

Add Taglib based extraction for Ogg, Flac, MP3, and MP4 files.