lp:~jamesh/go-unityscopes/go-1.6-compat

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:go-unityscopes/v2 at revision 74

dobey (community): Approve on 2016-10-03

Diff: 851 lines (+176/-121)

22 files modified

activationresponse.cpp (+5/-5)
activationresponse.go (+1/-1)
childscope.cpp (+3/-4)
childscope.go (+2/-3)
column_layout.cpp (+3/-9)
column_layout.go (+1/-6)
department.cpp (+7/-13)
department.go (+12/-4)
helpers.cpp (+15/-3)
helpers.go (+49/-0)
helpers.h (+5/-1)
metadata.cpp (+7/-8)
metadata.go (+7/-7)
query.cpp (+3/-3)
query.go (+5/-5)
reply.cpp (+8/-10)
reply.go (+6/-7)
result.cpp (+2/-2)
result.go (+2/-3)
shim.cpp (+3/-2)
shim.h (+29/-24)
unityscope.go (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1535157: breaks go 1.6 cgo pointer rules

High

Fix Released

Link a bug report

Related blueprints

84. By James Henstridge on 2016-04-18

Update Department.SetSubdepartments() to work with Go 1.6 pointer rules.
We now temporarily break shared_ptr invariants, but ensure all of the
underlying departments are referenced while this occurs.

83. By James Henstridge on 2016-04-18

Make StrData arguments const.

82. By James Henstridge on 2016-04-18

All the users of split_strings() were creating std::strings anyway, so
adjust the helper to match.

81. By James Henstridge on 2016-04-18

Convert cases where lists of strings were being passed across the cgo
boundary.

80. By James Henstridge on 2016-04-18

Remove old from_gostring() method, and add routines for transferring a
sequence of strings without breaking Go 1.6 pointer rules.

79. By James Henstridge on 2016-04-18

Update SearchReply/PreviewReply methods taking string values.

78. By James Henstridge on 2016-04-18

Update string handling in CannedQuery methods.

77. By James Henstridge on 2016-04-18

Update string passing in metadata methods.

76. By James Henstridge on 2016-04-15

Move department code over to strData().

75. By James Henstridge on 2016-04-14

Convert result.cpp uses of from_gostring().