Merge lp:~jamesh-f/ensoft-sextant/argparse-name-changes into lp:ensoft-sextant

[James]

Change names of command line arguments and format to which they are used.

Change names of command line arguments and format to which they are used. Make this consistent with the web page and documentation.

[Patrick Stevens (patrickas)]

review: Needs Fixing

[lp:~jamesh-f/ensoft-sextant/argparse-name-changes]

9. By James Harkin <email address hidden> on 2014-08-22

diff changes I see no merge conflicts though

[Patrick Stevens (patrickas)]

review: Needs Fixing

[lp:~jamesh-f/ensoft-sextant/argparse-name-changes]

10. By James Harkin <email address hidden> on 2014-08-22

merge

[Patrick Stevens (patrickas)]

review: Needs Fixing

[lp:~jamesh-f/ensoft-sextant/argparse-name-changes]

11. By James Harkin <email address hidden> on 2014-08-22

Documentation update ready for audit merge.

12. By James Harkin <email address hidden> on 2014-08-22

diff changes to documentation extra bracket

[Patrick Stevens (patrickas)]

review: Approve

=== modified file 'doc/Program_upload_docs.mkd' (properties changed: -x to +x)
--- doc/Program_upload_docs.mkd	2014-08-12 13:30:24 +0000
+++ doc/Program_upload_docs.mkd	2014-08-22 14:42:47 +0000
@@ -5,5 +5,5 @@
 Optionally, the flag `--ignore-function-pointers` can be provided to `program_upload.py` to cause the parser to pretend function pointer calls simply do not exist.
 
 # Query parameters
-We take the mandatory `--input-file`, a filepath for a program file whose call graph we wish to upload to the Neo4J server. Optionally we can specify that it is an ``--object-file` to have `objdump` run against it; otherwise, we assume the input was a text file consisting of `objdump`'s output.
+The first argument to upload a program to the database is "add-program", after which you should specify the file path to the program.  We can also if desired set the name of the program when stored in the database ("--names-in-db"). Optionally we can specify that it is not an object file (--not-object-file') so that instead of running `objdump` against it, we assume the input was a text file consisting of `objdump -D`'s output.
 Optional (if specified in config file) `--remote-neo4j`, the location of the Neo4J server (eg. `http://localhost:7474`).
\ No newline at end of file

=== modified file 'doc/wiki/Reference' (properties changed: -x to +x)
--- doc/wiki/Reference	2014-08-13 15:18:11 +0000
+++ doc/wiki/Reference	2014-08-22 14:42:47 +0000
@@ -10,31 +10,32 @@
 == File Management ==
 No more than one program can have the same name in the database.
 === Uploading a File ===
-set-file-name and not-object-file are optional.
+{{{ --name-in-db }}} and {{{ --not-object-file }}} are optional.
 {{{
-sextant add_program --input-file <name of file being input> --set-file-name <name file to be stored under in database> --not-object-file <True or False (default is False; pass through Objdump)>
+sextant add-program <name of file being input> --name-in-db <name file to be stored under in database> --not-object-file <True or False (default is False; pass through Objdump)>
 }}}
 === Deleting File ===
-It is good practice to delete files from the server since having many graphs in the database can lead to negative effects on performance.
+It is good practice to wipe files from the server since having many graphs in the database can lead to negative effects on performance.
 {{{
-sextant delete_program --program name <program name to be deleted as stored in database>
+sextant delete-program <program name to be deleted as stored in database>
 }}}
 == Queries ==
 === Command Line ===
 Command line queries produce a text output, either as a list or in GraphML which can be opened in yED.
 All queries take the form.
 {{{
-sextant query --program-name <program name> --query <query name>  --funcs <One or two functions as the arguments of the query> --suppress-common <True or False (default is False)>
+sextant query <query name> --program <program name (as stored in db to be queried)> --funcs <One or two functions as the arguments of the query> --suppress-common <True or False (default is False)>
 }}}
-Here common sense prevails. "return-all-program-names" doesn't have a "--program-name" argument or "--funcs" or "--suppress-common".  Similarly whole-graph doesn't take any "--funcs". "--suppress-common" is always optional and can only be used for a GraphML output.
-The options for queries are:
- * functions-calling,
- * functions-called-by,
- * calls-between,
- * whole-graph,
- * shortest-path,
- * return-all-program-names,
- * return-all-function-names.
+Regarding query arguments common sense prevails. {{{ programs }}} doesn't have a {{{ --program }}} argument or {{{ --funcs }}} or {{{ --suppress-common }}}.  Similarly whole-program doesn't take any {{{ --funcs }}} . {{{ --suppress-common }}} is always optional and can only be used for a GraphML output when specified in the command line.
+ || {{{ query }}} || {{{ --funcs }}} || {{{ --program }}} || {{{ --suppress-common }}} ||
+ || {{{ functions-calling }}} || *1 || *1 || opt ||
+ || {{{ functions-called-by }}} || *1 || *1 || opt ||
+ || {{{ all-call-paths }}} || *2 || *1 || opt ||
+ || {{{ whole-program }}} || *0 || *1 || opt ||
+ || {{{ shortest-call-path }}} || *2 || *1 || *0 ||
+ || {{{ programs }}} || *0 || *0 || *0 ||
+ || {{{ functions }}} || *0 || *1 || *0 ||
+A number signifies the number of arguments required, opt means the argument is allowed but is optional.
 For help with queries from the command line and the arguments type:
 {{{
 sextant query -h
@@ -42,4 +43,6 @@
 === Web ===
 To run the web server type
 {{{ sextant web }}}
-into the command line; then navigate a web browser to the port specified.
\ No newline at end of file
+into the command line; then navigate a web browser to the port specified.
+== Audit ==
+To see a more detailed view of a list of programs on the server type {{{ sextant audit }}} into the command line.  This will return a list of programs on the Neo4j server, specified in either the config file of command line, along with their unique program number, who uploaded them, that persons id and the date they were uploaded.
\ No newline at end of file

=== modified file 'resources/sextant/web/interface.html' (properties changed: -x to +x)
--- resources/sextant/web/interface.html	2014-08-19 09:25:06 +0000
+++ resources/sextant/web/interface.html	2014-08-22 14:42:47 +0000
@@ -55,9 +55,9 @@
                 All functions calling specific function</option>
             <option value="functions_called_by">
                 All functions called by a specific function</option>
-            <option value="call_paths">
+            <option value="all_call_paths">
                 All function call paths between two functions</option>
-            <option value="shortest_path">
+            <option value="shortest_call_path">
                 Shortest path between two functions</option>
             <option value="function_names">
                 All function names</option>

=== modified file 'resources/sextant/web/queryjavascript.js' (properties changed: -x to +x)
--- resources/sextant/web/queryjavascript.js	2014-08-14 15:23:39 +0000
+++ resources/sextant/web/queryjavascript.js	2014-08-22 14:42:47 +0000
@@ -86,7 +86,7 @@
 		document.getElementById("function_2").style.visibility = "hidden";
 		document.getElementById("function_2").value = null;
 	}
-	if (query_list.options[query_list.selectedIndex].value == "call_paths"){
+	if (query_list.options[query_list.selectedIndex].value == "all_call_paths"){
 		document.getElementById("argument_1").innerHTML = "Function calling";
 		document.getElementById("argument_2").innerHTML = "Function being called";
 		document.getElementById("function_1").readOnly = false;
@@ -94,7 +94,7 @@
 		document.getElementById("function_1").style.visibility = "visible";
 		document.getElementById("function_2").style.visibility = "visible";
 	}
-	if (query_list.options[query_list.selectedIndex].value == "shortest_path"){
+	if (query_list.options[query_list.selectedIndex].value == "shortest_call_path"){
 		document.getElementById("argument_1").innerHTML = "Function calling";
 		document.getElementById("argument_2").innerHTML = "Function being called";
 		document.getElementById("function_1").readOnly = false;

=== modified file 'src/sextant/__main__.py' (properties changed: -x to +x)
--- src/sextant/__main__.py	2014-08-21 13:03:24 +0000
+++ src/sextant/__main__.py	2014-08-22 14:42:47 +0000
@@ -107,34 +107,37 @@
 
 # add each subparser in turn to the parsers dictionary
 
-parsers['add'] = subparsers.add_parser('add_program', help="add a program to the database")
-parsers['add'].add_argument('--input-file', required=True, metavar="FILE_NAME",
+parsers['add'] = subparsers.add_parser('add-program',
+                                       help="add a program to the database")
+parsers['add'].add_argument('input_file', metavar="FILE_NAME",
                             help="name of file to be put into database",
-                            type=str, nargs=1)
-parsers['add'].add_argument('--set-file-name', metavar="FILE_NAME",
+                            type=str)
+parsers['add'].add_argument('--name-in-db', metavar="PROGRAM_NAME",
                             help="string to store this program under", type=str,
                             nargs=1)
 parsers['add'].add_argument('--not-object-file',
-                            help='default False, if the input file is an object to be disassembled',
+                            help='default False, if the input file is an '
+                                 'object to be disassembled',
                             action='store_true')
 
-parsers['delete'] = subparsers.add_parser('delete_program',
+parsers['delete'] = subparsers.add_parser('delete-program',
                                           help="delete a program from the database")
-parsers['delete'].add_argument('--program-name', required=True, metavar="PROG_NAME",
+parsers['delete'].add_argument('program_name', metavar="PROG_NAME",
                                help="name of program as stored in the database",
-                               type=str, nargs=1)
+                               type=str)
 
 parsers['query'] = subparsers.add_parser('query',
                                          help="make a query of the database")
-parsers['query'].add_argument('--program-name', metavar="PROG_NAME",
-                              help="name of program as stored in the database",
-                              type=str, nargs=1)
-parsers['query'].add_argument('--query', required=True, metavar="QUERY",
+parsers['query'].add_argument('query', metavar="QUERY",
                               help="functions-calling, functions-called-by, "
-                                   "calls-between, whole-graph, shortest-path, "
-                                   "return-all-program-names or "
-                                   "return-all-function-names; if the latter, "
-                                   "supply argument --program-name",
+                                   "all-call-paths, whole-program, "
+                                   "shortest-call-path, programs or "
+                                   "functions; if the latter, "
+                                   "supply argument --program",
+                              type=str)
+parsers['query'].add_argument('--program', metavar="PROG_NAME",
+                              help="name of program as stored in the database; "
+                                   "required for all queries except 'programs'",
                               type=str, nargs=1)
 parsers['query'].add_argument('--funcs', metavar='FUNCS',
                               help='functions to pass to the query',
@@ -168,15 +171,14 @@
 parsers['web'].set_defaults(func=_start_web)
 
 def add_file(namespace):
-
     try:
-        alternative_name = namespace.set_file_name[0]
+        alternative_name = namespace.name_in_db[0]
     except TypeError:
         alternative_name = None
 
     not_object_file = namespace.not_object_file
     # the default is "yes, this is an object file" if not-object-file was
-    # unsupplied
+    # unsupplied=
     try:
         update_db.upload_program(namespace.input_file[0],
                                  namespace.remote_neo4j,
@@ -193,9 +195,8 @@
     except ValueError as e:
         logging.error(e)
 
-
 def delete_file(namespace):
-    update_db.delete_program(namespace.program_name[0],
+    update_db.delete_program(namespace.program_name,
                              namespace.remote_neo4j)
 
 parsers['add'].set_defaults(func=add_file)
@@ -203,7 +204,6 @@
 
 
 def make_query(namespace):
-
     arg1 = None
     arg2 = None
     try:
@@ -211,9 +211,11 @@
         arg2 = namespace.funcs[1]
     except TypeError:
         pass
+    except IndexError:
+        pass
 
     try:
-        program_name = namespace.program_name[0]
+        program_name = namespace.program[0]
     except TypeError:
         program_name = None
 
@@ -223,7 +225,7 @@
         suppress_common = False
 
     query.query(remote_neo4j=namespace.remote_neo4j,
-                input_query=namespace.query[0],
+                input_query=namespace.query,
                 program_name=program_name, argument_1=arg1, argument_2=arg2,
                 suppress_common=suppress_common)
 

=== modified file 'src/sextant/query.py' (properties changed: -x to +x)
--- src/sextant/query.py	2014-08-19 09:20:45 +0000
+++ src/sextant/query.py	2014-08-22 14:42:47 +0000
@@ -42,19 +42,19 @@
             print('Supply one function name to functions-called-by.')
             return 1
         prog = db.get_all_functions_called(program_name, argument_1)
-    elif input_query == 'calls-between':
+    elif input_query == 'all-call-paths':
         if (argument_1 == None and argument_2 == None):
             print('Supply two function names to calls-between.')
             return 1
         prog = db.get_call_paths(program_name, argument_1, argument_2)
-    elif input_query == 'whole-graph':
+    elif input_query == 'whole-program':
         prog = db.get_whole_program(program_name)
-    elif input_query == 'shortest-path':
+    elif input_query == 'shortest-call-path':
         if argument_1 == None and argument_2 == None:
             print('Supply two function names to shortest-path.')
             return 1
         prog = db.get_shortest_path_between_functions(program_name, argument_1, argument_2)
-    elif input_query == 'return-all-function-names':
+    elif input_query == 'functions':
         if program_name != None:
             func_names = db.get_function_names(program_name)
             if func_names:
@@ -73,7 +73,7 @@
                 print('Server %s contains no functions.' % (remote_neo4j))
             else:
                 names_list = func_list
-    elif input_query == 'return-all-program-names':
+    elif input_query == 'programs':
         list_found = list(db.get_program_names())
         if not list_found:
             print('No programs were found on server {}.'.format(remote_neo4j))
@@ -90,24 +90,5 @@
     else:
         print('Nothing was returned from the query.')
 
-
-def main():
-    argumentparser = argparse.ArgumentParser(description="Return GraphML representation or list from graph queries.")
-    argumentparser.add_argument('--remote-neo4j', required=True, metavar="URL", help="URL of neo4j server", type=str, nargs=1)
-    argumentparser.add_argument('--program-name', metavar="PROG_NAME", help="name of program as stored in the database",
-                                type=str, nargs=1)
-    argumentparser.add_argument('--query', required=True, metavar="QUERY",
-                                help="""functions-calling, functions-called-by, calls-between, whole-graph, shortest-path,
-                                return-all-program-names or return-all-function-names; if return-all-function-names,
-                                supply argument -program-name""", type=str, nargs=1)
-    argumentparser.add_argument('--funcs', metavar='FUNCS', help='functions to pass to the query', type=str, nargs='+')
-
-    parsed = argumentparser.parse_args()
-    names_list = None
-
-    query(remote_neo4j=parsed.remote_neo4j[0], input_query=parsed.query[0], arguments=parsed.funcs,
-          program_name=parsed.program_name[0])
-
-
 if __name__ == '__main__':
     main()

=== modified file 'src/sextant/web/server.py' (properties changed: -x to +x)
--- src/sextant/web/server.py	2014-08-20 09:04:45 +0000
+++ src/sextant/web/server.py	2014-08-22 14:42:47 +0000
@@ -148,7 +148,7 @@
                 defer.returnValue(None)
             func1 = request.args['func1'][0]
             program = yield deferToThread(neo4jconnection.get_all_functions_called, name, func1)
-        elif query == 'call_paths':
+        elif query == 'all_call_paths':
             if 'func1' not in request.args:
                 # raise 400 Bad Request error
                 request.setResponseCode(400)
@@ -165,7 +165,7 @@
             func1 = request.args['func1'][0]
             func2 = request.args['func2'][0]
             program = yield deferToThread(neo4jconnection.get_call_paths, name, func1, func2)
-        elif query == 'shortest_path':
+        elif query == 'shortest_call_path':
             if 'func1' not in request.args:
                 # raise 400 Bad Request error
                 request.setResponseCode(400)