Code review comment for lp:~jamesbeedy/charms/trusty/wordpress/apache2_trusty_fix

Revision history for this message
Pen Gale (pengale) wrote :

The code makes sense, and the charm deploys successfully and tests pass. +1

(It looks like there might be an issue with the tests when run via bundletester -- they pass, but leave the wordpress machine in a "hook failed: cache-relation-changed" for memcached:cache" state. The precise tests in trunk do the same thing, however, so I don't believe that it is related to this code, or should block this PR from being merged.)

review: Approve

« Back to merge proposal