Code review comment for ~jamesbeedy/charm-grafana:relation_base_to_endpoint

Revision history for this message
Drew Freiberger (afreiberger) wrote :

inline comment below. I think there's an issue with either implementation's logic when we migrate prometheus/influxdb/other grafana-source units but keep the relation.

Either way, I think we have an issue and we'd have to break and re-create the relation if datasources move, if I'm reading the surrounding code accurately.

Agree, this needs some real world testing. I'll address this tomorrow.

« Back to merge proposal