Code review comment for ~jamesbeedy/charm-grafana:relation_base_to_endpoint

Revision history for this message
Paul Goins (vultaire) wrote :

Did an initial review.

It looks sane. I'm not sure I've personally dealt with conversations vs. endpoints, but the change makes sense.

I'm not yet ready to +1, as I think some hands-on checking and testing is appropriate here. Further, there's the related changes to interface-grafana-source (https://code.launchpad.net/~jamesbeedy/interface-grafana-source/+git/interface-grafana-source/+merge/393217) which I'm guessing is related here - I haven't looked deeply enough quite to know for sure.

To be clear, this isn't waiting on the author; this is waiting for reviewers (maybe me) to dig into the above points and make sure this won't break.

« Back to merge proposal