Merge lp:~james-w/udd/ubuntu-dev-review into lp:udd

[James Westby]

Hi,

There were two reasons this code was disabled:

  1) Too much email would be generated, but I had the email setup of ~ubuntu-dev changed so that this will end up on a catch-all mailing list.
  2) Too many reviews. There were teething problems that meant there were too many reviews requested due to bugs, but they are infrequent now, and we should get the visibility and then fix them.

Talking about this in #ubuntu-dev Daviey suggested that we notify the
uploader and the person that pushed (or last committer or something).

For the former we should be able to get this fairly easily using attributes
in launchpadlib. For the latter we will likely have to do Launchpad.people.getByEmail()
with some email addresses on a best effort basis.

Thanks,

James

[Martin Pool (mbp)]

review: Approve

=== modified file 'import_package.py'
--- import_package.py	2011-02-08 02:53:42 +0000
+++ import_package.py	2011-03-01 20:58:00 +0000
@@ -492,13 +492,15 @@
     lp_branch = icommon.lp_call(lp.load, lp_url)
     target_branch_url = bstore._branch_url(distro, release, pocket)
     target_lp_branch = icommon.lp_call(lp.load, target_branch_url)
+    # It would be great to notify the uploader and pusher of the merge
+    # proposal, but let's start with ~ubuntu-dev.
     ubuntu_dev = icommon.lp_call(operator.getitem, lp.people, 'ubuntu-dev')
     mp = icommon.lp_call(lp_branch.createMergeProposal,
             target_branch=target_lp_branch,
             initial_comment=bug_description(distro, release, pocket, name,
                 lp_side_branch_path),
-            needs_review=False,
-            #reviewers=[ubuntu_dev.self_link],
+            needs_review=True,
+            reviewers=[ubuntu_dev.self_link],
             )
     mutter("Merge proposal filed: %s" % str(mp.self_link))