Merge lp:~james-w/udd/packages-last-update into lp:udd

[James Westby]

Return a datetime from PackageDatabase.last_update() too.

Hi,

This is one more bit of fallout from the storm change that the overnight
cronjobs found.

Thanks,

James

[Jonathan Lange (jml)]

review: Approve

=== modified file 'udd/icommon.py'
--- udd/icommon.py	2012-04-04 17:32:38 +0000
+++ udd/icommon.py	2012-04-05 17:26:21 +0000
@@ -914,8 +914,8 @@
             row = c.execute('select * from %s order by anupdate desc'
                     % self.UPDATE_TABLE).get_one()
             if row is not None:
-                return row[0]
-            return row
+                return make_datetime(row[0])
+            return None
 
     def update_packages(self, package_dict):
         with Cursor(self.conn) as c:

=== modified file 'udd/tests/test_package_database.py'
--- udd/tests/test_package_database.py	2012-03-23 16:56:38 +0000
+++ udd/tests/test_package_database.py	2012-04-05 17:26:21 +0000
@@ -1,3 +1,5 @@
+from datetime import datetime
+
 from bzrlib import tests
 
 from udd import icommon, idb
@@ -12,6 +14,10 @@
     def test_last_update_in_empty(self):
         self.assertEquals(None, self.db.last_update())
 
+    def test_last_update(self):
+        self.db.update_packages({})
+        self.assertIsInstance(self.db.last_update(), datetime)
+
     def test_update_packages(self):
         self.db.update_packages({'foo': 1, 'bar': 0})
         self.assertEquals(set(['foo']), self.db.list_packages_in_main())