Merge lp:~james-w/ubuntu-seeds/ubuntu.karmic-kerneloops into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu.karmic

Proposed by James Westby
Status: Merged
Merged at revision: not available
Proposed branch: lp:~james-w/ubuntu-seeds/ubuntu.karmic-kerneloops
Merge into: lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu.karmic
Diff against target: None lines
To merge this branch: bzr merge lp:~james-w/ubuntu-seeds/ubuntu.karmic-kerneloops
Reviewer Review Type Date Requested Status
Registry Administrators Pending
Review via email: mp+10768@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

Seed kerneloops.

Recommends in the desktop seed to get it by default in
to desktop installs, but allow people to use it.

Depends in server-ship to allow it to be easily installed
on servers. It recommends apport, so putting it in server
would pull in apport, which is currently only server-ship.

Thanks,

James

Revision history for this message
Colin Watson (cjwatson) wrote :

(I assume you just want extra eyes, as you can commit this yourself.)

Any reason why you haven't seeded the applet in desktop? Indeed, since
it depends on the daemon, you should only need to seed the applet
explicitly.

Otherwise this looks fine.

Revision history for this message
James Westby (james-w) wrote :

On Wed Aug 26 20:33:09 UTC 2009 Colin Watson wrote:
> (I assume you just want extra eyes, as you can commit this yourself.)

Yeah, my first real seed change, so I wanted to make sure I had the right idea.

Do I need to merge this to other seed collections(?) (kubuntu etc?, we want
it in at least ubuntu/kubuntu and probably xubuntu)

> Any reason why you haven't seeded the applet in desktop? Indeed, since
> it depends on the daemon, you should only need to seed the applet
> explicitly.

Because we don't want to use the applet?

My changes have been such that we now have apport to the prompting,
so that you get one thing asking you, even if it currently asks
you about LP and kerneloops.org separately.

> Otherwise this looks fine.

Great, thanks,

James

Revision history for this message
Colin Watson (cjwatson) wrote :

On Wed, Aug 26, 2009 at 09:09:08PM -0000, James Westby wrote:
> Yeah, my first real seed change, so I wanted to make sure I had the right idea.
>
> Do I need to merge this to other seed collections(?) (kubuntu etc?, we want
> it in at least ubuntu/kubuntu and probably xubuntu)

You can put kerneloops-daemon in the desktop-common seed in
platform.karmic instead, and then you don't have to merge anything -
it'll apply to all desktop-ish products.

> > Any reason why you haven't seeded the applet in desktop? Indeed, since
> > it depends on the daemon, you should only need to seed the applet
> > explicitly.
>
> Because we don't want to use the applet?
>
> My changes have been such that we now have apport to the prompting,
> so that you get one thing asking you, even if it currently asks
> you about LP and kerneloops.org separately.

Oh, gotcha. OK then.

Revision history for this message
James Westby (james-w) wrote :

On Wed Aug 26 21:18:09 UTC 2009 Colin Watson wrote:
> On Wed, Aug 26, 2009 at 09:09:08PM -0000, James Westby wrote:
> > Yeah, my first real seed change, so I wanted to make sure I had the right idea.
> >
> > Do I need to merge this to other seed collections(?) (kubuntu etc?, we want
> > it in at least ubuntu/kubuntu and probably xubuntu)
>
> You can put kerneloops-daemon in the desktop-common seed in
> platform.karmic instead, and then you don't have to merge anything -
> it'll apply to all desktop-ish products.

Great, thanks, I'll make that change and merge tomorrow.

Thanks,

James

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'desktop'
2--- desktop 2009-08-25 13:42:04 +0000
3+++ desktop 2009-08-26 19:22:00 +0000
4@@ -200,4 +200,5 @@
5 * xsplash
6 * (example-content) # dholbach: dapper feature goal (wiki.ubuntu.com/ExampleContent)
7 * (libwmf0.2-7-gtk)
8+ * (kerneloops-daemon)
9
10
11=== modified file 'server-ship'
12--- server-ship 2009-08-20 09:18:21 +0000
13+++ server-ship 2009-08-26 19:22:00 +0000
14@@ -332,6 +332,7 @@
15 * lilo
16 * checkbox-cli # MathiasGug
17 * apport # MathiasGug
18+ * kerneloops-daemon # JamesWestby
19
20 = From desktop =
21

Subscribers

People subscribed via source and target branches