Merge lp:~james-w/python-oops/update-readme-dependencies into lp:python-oops

[James Westby]

Hi,

The setup.py doesn't mention that bson is needed, and the
README misses most of the dependencies.

Thanks,

James

[Richard Harding (rharding)]

In looking through the code I don't see where bson is required. It's not listed in the versions.cfg that is used to pull dependencies and going through the code there are a couple of comments about being bson compatible, but nothing is imported from the bson library.

iso8601 I see is in the setup.py and versions.cfg, but again I don't see it actually imported and used in the code. I'm curious if that is required any longer either. Can you verify that without that dependency that the tests fail?

Adding the pytz is valid.

review: Needs Fixing (code*)

[lp:~james-w/python-oops/update-readme-dependencies]

29. By James Westby on 2012-01-26

python-oops doesn't require bson after all.

[j.c.sackett (jcsackett)]

Thanks for dropping the bson bit. I think determining if iso8601 is fully required or not is out of scope of a small branch like this, and I don't want to increase the impedance of getting this change in.

review: Approve

[James Westby (james-w)]

Hi,

I just checked iso8601 and Rick is right, the tests all pass without it, so I
dropped it.

Thanks,

James

[lp:~james-w/python-oops/update-readme-dependencies]

30. By James Westby on 2012-01-26

iso8601 isn't needed either. Thanks Rick.

[James Westby (james-w)]

btw, I can't land this myself, so I'll need some assistance there.

Thanks,

James

[Richard Harding (rharding)]

Thanks, I'll see about helping with landing.

review: Approve (code*)

=== modified file 'README'
--- README	2011-11-13 21:24:42 +0000
+++ README	2012-01-26 14:58:24 +0000
@@ -29,6 +29,7 @@
 ============
 
 * Python 2.6+
+* pytz (http://pypi.python.org/pypi/pytz/)
 
 Testing Dependencies
 ====================

=== modified file 'setup.py'
--- setup.py	2011-11-13 21:28:06 +0000
+++ setup.py	2012-01-26 14:58:24 +0000
@@ -39,7 +39,6 @@
           'Programming Language :: Python',
           ],
       install_requires = [
-          'iso8601',
           'pytz',
           ],
       extras_require = dict(