Merge lp:~james-w/python-oops-dictconfig/bool-new-only into lp:python-oops-dictconfig

Proposed by James Westby
Status: Merged
Approved by: James Westby
Approved revision: 16
Merged at revision: 15
Proposed branch: lp:~james-w/python-oops-dictconfig/bool-new-only
Merge into: lp:python-oops-dictconfig
Diff against target: 22 lines (+4/-1)
1 file modified
oops_dictconfig/configglue_options.py (+4/-1)
To merge this branch: bzr merge lp:~james-w/python-oops-dictconfig/bool-new-only
Reviewer Review Type Date Requested Status
Anthony Lenton (community) Approve
Review via email: mp+150588@code.launchpad.net

Commit message

Make new_only a BoolOption.

Description of the change

Hi,

This makes new_only a BoolOption so that it can be set correctly with configglue.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Anthony Lenton (elachuni) wrote :

Thanks!

review: Approve
16. By James Westby

Add inherit_id.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'oops_dictconfig/configglue_options.py'
2--- oops_dictconfig/configglue_options.py 2013-02-06 17:00:45 +0000
3+++ oops_dictconfig/configglue_options.py 2013-02-26 16:17:20 +0000
4@@ -24,7 +24,7 @@
5 type=schema.StringOption(
6 help="Type of publisher; amqp or datedir are supported.",
7 ),
8- new_only=schema.StringOption(
9+ new_only=schema.BoolOption(
10 help="Only publish if a previous publisher hasn't.",
11 ),
12 error_dir=schema.StringOption(
13@@ -49,6 +49,9 @@
14 routing_key=schema.StringOption(
15 help=("For amqp: the routing key for the amqp broker."),
16 ),
17+ inherit_id=schema.BoolOption(
18+ help="Re-use any oops id that is already present in the oops.",
19+ ),
20 )
21 if 'help' not in kwargs:
22 kwargs['help'] = "Config for an oops publisher."

Subscribers

People subscribed via source and target branches