Merge lp:~james-w/python-oops-amqp/new-publisher-api into lp:python-oops-amqp
Proposed by
James Westby
Status: | Needs review |
---|---|
Proposed branch: | lp:~james-w/python-oops-amqp/new-publisher-api |
Merge into: | lp:python-oops-amqp |
Diff against target: |
68 lines (+11/-9) 4 files modified
README (+1/-0) oops_amqp/__init__.py (+8/-7) oops_amqp/tests/test_publisher.py (+1/-2) versions.cfg (+1/-0) |
To merge this branch: | bzr merge lp:~james-w/python-oops-amqp/new-publisher-api |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert Collins | Pending | ||
Review via email: mp+112951@code.launchpad.net |
Commit message
Provide the new publisher API.
Description of the change
Hi,
Here's a sketch of how the new publisher API could be provided in
oops_amqp.
I think the name is terrible, so suggestions are welcome.
Thanks,
James
To post a comment you must log in.
Unmerged revisions
- 14. By James Westby
-
Merge trunk.
- 13. By James Westby
-
Update the requirements to demand the new API from oops.
- 12. By James Westby
-
Switch to breaking API rather than adding a new Publisher object.
Also update the users of the publish() API in the test-suite to expect
the new behaviour. - 11. By James Westby
-
A sketch of the new publisher API in oops_amqp.
PublisherV2 is a bad name.
A few thoughts: we decided to whine on all legacy publishers in the
oops codebase, so there is little reason to preserve compat here: when
someone updates they can just move the publisher to the new config. As
such, I'd not change the name.
That should make the patch quite a bit smaller.