PQM

Merge lp:~james-w/pqm/tags into lp:pqm

Proposed by James Westby
Status: Merged
Merge reported by: Robert Collins
Merged at revision: not available
Proposed branch: lp:~james-w/pqm/tags
Merge into: lp:pqm
Diff against target: 19 lines
To merge this branch: bzr merge lp:~james-w/pqm/tags
Reviewer Review Type Date Requested Status
Robert Collins Pending
Review via email: mp+3659@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

PQM didn't try and merge the tags from a bzr branch when doing star merge,
making it hard to provide tags in the trunk of a project.

Thanks,

James

Revision history for this message
Robert Collins (lifeless) wrote :

However, next time you put a branch up for merge, please run the test
suite first. You would have seen your code was broken :)

Tests would be better, but I want to clear the decks so am just doing
it.

-Rob

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'pqm/__init__.py'
2--- pqm/__init__.py 2008-08-05 06:31:49 +0000
3+++ pqm/__init__.py 2009-03-05 06:50:07 +0000
4@@ -418,6 +418,7 @@
5
6 def _do_star_merge(self, sender, from_branch, local_dir, tree):
7 from bzrlib.merge import Merger, Merge3Merger
8+ from bzrlib.tag import _merge_tags_if_possible
9 merger = Merger(tree.branch, this_tree=tree)
10 merger.check_basis(True)
11 merger.set_other([from_branch, -1])
12@@ -440,6 +441,7 @@
13 finally:
14 tree.unlock()
15 raise PQMTlaFailure(sender, error_lines)
16+ _merge_tags_if_possible(from_branch, tree.branch)
17 return ["merge successful"]
18
19 def make_local_dir(self, sender, branch_spec, output_dir):

Subscribers

People subscribed via source and target branches