Merge lp:~james-w/pkgme/extra_files_from_paths into lp:pkgme

[James Westby]

Add extra_files_from_paths to all extra binary files.

Hi,

This allows us to provide icons in the binary backends, as extra_files
isn't usable with binary files.

I added to the XXX code that breaks the layering, but I couldn't come up
with a better strategy that wasn't also much more complex.

Another alternative would be to not read the paths in pkgme, but have
extra_files_base64 or something. This just seemed a bit easier for backends,
but it may be problematic. For instance the filename is assumed to be
absolute, and allowing relative paths would mean the InfoElement knowing
about the path that it is acting on.

Thanks,

James

[lp:~james-w/pkgme/extra_files_from_paths]

94. By James Westby on 2011-12-22

Target filename must be absolute path.

[Jonathan Lange (jml)]

Looks good to me. Would be good to have a docstring for FileFromDisk.

review: Approve

[James Westby (james-w)]

Added.

Thanks,

James

[lp:~james-w/pkgme/extra_files_from_paths]

95. By James Westby on 2012-01-10

Add a docstring to FileFromDisk. Thanks jml.