pkgme service

Merge lp:~james-w/pkgme-service/review-click into lp:pkgme-service

  1. review-click
  2. Merge into trunk
Proposed by James Westby
Status: Merged
Approved by: James Westby
Approved revision: 148
Merged at revision: 148
Proposed branch: lp:~james-w/pkgme-service/review-click
Merge into: lp:pkgme-service
Diff against target: 23 lines (+2/-0)
2 files modified
src/djpkgme/tasks.py (+1/-0)
src/djpkgme/tests/test_tasks.py (+1/-0)
To merge this branch: bzr merge lp:~james-w/pkgme-service/review-click
Reviewer Review Type Date Requested Status
James Westby (community) Approve
Review via email: mp+193646@code.launchpad.net

Commit message

Improve formatting of the explanation for package name mismatch.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

trivial

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/djpkgme/tasks.py'
2--- src/djpkgme/tasks.py 2013-10-31 18:58:04 +0000
3+++ src/djpkgme/tasks.py 2013-11-01 18:11:17 +0000
4@@ -426,6 +426,7 @@
5 if manifest_content['name'] != metadata['package_fullname']:
6 result['passed'] = False
7 result['explanation'] = '''Package name in the manifest: `{}`
8+
9 Package name in My Apps: `{}`
10 '''.format(manifest_content['name'], metadata['package_fullname'])
11 return result
12
13=== modified file 'src/djpkgme/tests/test_tasks.py'
14--- src/djpkgme/tests/test_tasks.py 2013-10-31 18:58:04 +0000
15+++ src/djpkgme/tests/test_tasks.py 2013-11-01 18:11:17 +0000
16@@ -550,6 +550,7 @@
17 result = job.check_package_name_matches(metadata, tempdir)
18 self.assertEqual(False, result['passed'])
19 explanation = '''Package name in the manifest: `{}`
20+
21 Package name in My Apps: `{}`
22 '''.format(other_package_name, package_name)
23 self.assertEqual(explanation, result['explanation'])

Subscribers

People subscribed via source and target branches