Merge lp:~james-w/pkgme-service-python/buildout into lp:pkgme-service-python
| Status: | Merged |
|---|---|
| Approved by: | Jonathan Lange on 2012-07-31 |
| Approved revision: | 21 |
| Merged at revision: | 17 |
| Proposed branch: | lp:~james-w/pkgme-service-python/buildout |
| Merge into: | lp:pkgme-service-python |
| Diff against target: |
1051 lines (+932/-37) 9 files modified
.bzrignore (+6/-4) HACKING (+28/-6) Makefile (+59/-17) bootstrap.py (+262/-0) buildout.cfg (+36/-0) distribute_setup.py (+515/-0) tarmac_tests.sh (+2/-5) test-dependencies.txt (+0/-5) versions.cfg (+24/-0) |
| To merge this branch: | bzr merge lp:~james-w/pkgme-service-python/buildout |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jonathan Lange (community) | 2012-07-26 | Approve on 2012-07-30 | |
|
Review via email:
|
|||
Commit Message
Switch to buildout.
Description of the Change
Hi,
Here's a stab at moving a project to buildout.
Some issues:
* buildout is very tempremental trying to bootstrap.
- If you have it installed system-wide then you can't use the
bootstrap.py. You can work around this by doing the bootstrap
in a virtualenv, but that's not particularly nice.
- This branch uses the system-wide one. I think the drawback of that
is that everyone will have to use exactly the same version.
- I can't really work out how LP is avoiding these issues. I suspect
they aren't.
* The Makefile dependencies are a little off, e.g. after a bootstrap
a check will do a quick buildout run, and subsequent runs won't.
* There's no depenencies branch to use yet.
* I don't know if we can speed things up with sharing the eggs dir between
branches. As it stands this branch is a few seconds slower to bootstrap
than trunk. I don't know if that will reverse on larger projects (I
suspect it will though.)
I'm mainly posting this for discussion at this point.
Thanks,
James
- 18. By James Westby on 2012-07-27
-
Switch to distribute and add a note about site-wide buildout.
| James Westby (james-w) wrote : | # |
- 19. By James Westby on 2012-07-27
-
Symlink the eggs by default.
| James Westby (james-w) wrote : | # |
and yes we can share eggs (link-external-
It speeds up subsequent bootstraps immensely, and there's little
risk of contamination.
I've taken a stab at doing it by default with no extra steps, but
I'm not sure if using the parent dir will be appreciated.
Thanks,
James
| Jonathan Lange (jml) wrote : | # |
Looks good. Thanks for exploring this! I've pinged benji & gary_poster on IRC to take a look as well.
Is the shared eggs directory is inherited from the environment? ISTR buildout has a facility for this already, but I can't recall exactly?
Also, in case you haven't read it, http://
Thanks,
jml
| Jonathan Lange (jml) wrote : | # |
* EGGS_DIR being set works.
* Works for me.
* Probably should add lp:ca-download-cache step to either Makefile or documentation
- 20. By James Westby on 2012-07-30
-
Checkout the download-cache too, and use more specific variable names.
- 21. By James Westby on 2012-07-30
-
Explain the env vars in the HACKING doc.
| James Westby (james-w) wrote : | # |
On Mon, 30 Jul 2012 16:12:20 -0000, Jonathan Lange <email address hidden> wrote:
> * Probably should add lp:ca-download-cache step to either Makefile or documentation
Added to both. I also made the names of the env vars more specific.
Thanks,
James

I investigated the site-wide thing some more, and filed
https:/ /bugs.launchpad .net/zc. buildout/ +bug/1029715
The workaround I'm using for now is to require v1.5.1 of buildout,
so it works for precise users, even if they have buildout installed
via apt.
Thanks,
James