Merge lp:~james-w/pkgme-devportal/libdep-service-close into lp:pkgme-devportal

[James Westby]

Add a close method to LibdepServiceClient.

Hi,

Testing on staging revealed that there is a bug because the libdep-service
database has no close method.

This probably indicates that we should have a better test for this (switching
integration tests to use the double). I'll do this tomorrow, but I wanted to
get this up before leaving.

Thanks,

James

[Jonathan Lange (jml)]

Sure, I'll buy that.

review: Approve

=== modified file 'devportalbinary/database.py'
--- devportalbinary/database.py	2012-10-16 21:59:28 +0000
+++ devportalbinary/database.py	2012-10-22 22:18:20 +0000
@@ -503,6 +503,9 @@
         return self._client.get_binaries_for_libraries(library_name,
                                                        [arch])[arch]
 
+    def close(self):
+        pass
+
 
 def get_dependency_database():
     """Return an object that can get dependencies."""

=== modified file 'devportalbinary/tests/test_database.py'
--- devportalbinary/tests/test_database.py	2012-10-16 21:59:28 +0000
+++ devportalbinary/tests/test_database.py	2012-10-22 22:18:20 +0000
@@ -461,3 +461,9 @@
         self.assertEqual(
             {'libfoo': ['libfoo-bin']},
             wrapper.get_dependencies(['libfoo'], 'i386'))
+
+    def test_has_close_method(self):
+        client = Client('http://localhost/')
+        wrapper = LibdepServiceClient(client)
+        # Check that there is no exception
+        wrapper.close()