Merge lp:~james-w/pkgme-devportal/enable-tests into lp:pkgme-devportal

[James Westby]

Run the tests in tarmac.

Hi,

This branch changes tarmac to run the tests for pkgme-binary.

Thanks,

James

[Jonathan Lange (jml)]

Looks good.

review: Approve

[Canonical CA Tarmac (ca-tarmac)]

The attempt to merge lp:~james-w/pkgme-binary/enable-tests into lp:pkgme-binary failed. Below is the output from the failed tests.

Tests running...
======================================================================
ERROR: tests.test_binary.GuessDependenciesTests.test_guess_dependencies
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tmpbJ0y4f/devportalbinary/tests/test_binary.py", line 308, in test_guess_dependencies
    deps = guess_dependencies(os.path.dirname(__file__))
  File "devportalbinary/binary.py", line 231, in guess_dependencies
    libraries = get_shared_library_dependencies(binaries, library_finder)
TypeError: get_shared_library_dependencies() takes exactly 1 argument (2 given)
======================================================================
ERROR: tests.test_binary_backend.BinaryBackendTests.test_build_depends
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/tmpbJ0y4f/devportalbinary/tests/test_binary_backend.py", line 76, in test_build_depends
    deps = ', '.join(guess_dependencies(tempdir.path))
  File "devportalbinary/binary.py", line 231, in guess_dependencies
    libraries = get_shared_library_dependencies(binaries, library_finder)
TypeError: get_shared_library_dependencies() takes exactly 1 argument (2 given)

Ran 51 tests in 2.657s
FAILED (failures=2)

Branched 91 revision(s).
/tmp/tmpbJ0y4f/virtualenv/lib/python2.6/site-packages/distribute-0.6.10-py2.6.egg/setuptools/command/bdist_egg.py:422: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
  symbols = dict.fromkeys(iter_symbols(code))
bzrlib/_readdir_pyx.c: In function '__pyx_f_6bzrlib_12_readdir_pyx__read_dir':
bzrlib/_readdir_pyx.c:992: warning: '__pyx_exc_lineno' may be used uninitialized in this function
bzrlib/_readdir_pyx.c:1035: warning: '__pyx_exc_lineno' may be used uninitialized in this function
bzrlib/_chk_map_pyx.c: In function '__pyx_f_6bzrlib_12_chk_map_pyx_safe_interned_string_from_size':
bzrlib/_chk_map_pyx.c:282: warning: cast from pointer to integer of different size
In file included from /usr/include/python2.6/Python.h:8,
                 from bzrlib/_patiencediff_c.c:28:
/usr/include/python2.6/pyconfig.h:1031:1: warning: "_POSIX_C_SOURCE" redefined
In file included from /usr/include/stdlib.h:25,
                 from bzrlib/_patiencediff_c.c:26:
/usr/include/features.h:210:1: warning: this is the location of the previous definition
bzrlib/_btree_serializer_pyx.c: In function '__pyx_f_6bzrlib_21_btree_serializer_pyx_safe_string_from_size':
bzrlib/_btree_serializer_pyx.c:880: warning: cast from pointer to integer of different size
bzrlib/_btree_serializer_pyx.c: In function '__pyx_f_6bzrlib_21_btree_serializer_pyx_safe_interned_string_from_size':
bzrlib/_btree_serializer_pyx.c:974: warning: cast from pointer to integer of different size
/tmp/tmpbJ0y4f/virtualenv/lib/python2.6/site-packages/distribute-0.6.10-py2.6.egg/setuptools/command/bdist_egg.py:422: UnicodeWarning: Unicode equal comparison failed to convert both arguments to U...

[lp:~james-w/pkgme-devportal/enable-tests]

22. By James Westby on 2011-12-08

Merge trunk.

23. By James Westby on 2011-12-08

Fix the broken tests.

=== modified file 'devportalbinary/binary.py'
--- devportalbinary/binary.py	2011-12-08 12:53:11 +0000
+++ devportalbinary/binary.py	2011-12-08 15:46:23 +0000
@@ -228,7 +228,7 @@
     library_finder=needed_libraries_from_objdump,
     libraries_to_deps=get_packages_for_libraries):
     binaries = iter_binaries(path)
-    libraries = get_shared_library_dependencies(binaries, library_finder)
+    libraries = get_shared_library_dependencies(binaries)
     deps = libraries_to_deps(libraries, 'i386')
     return deps
 

=== modified file 'tarmac_tests.sh'
--- tarmac_tests.sh	2011-12-07 20:33:05 +0000
+++ tarmac_tests.sh	2011-12-08 15:46:23 +0000
@@ -2,4 +2,11 @@
 
 set -e
 
-echo "No tests yet."
+virtualenv --no-site-packages virtualenv > log
+. ./virtualenv/bin/activate >> log
+pip install discover >> log
+bzr branch lp:pkgme pkgme >> log
+(cd pkgme && python setup.py develop) >> log
+python setup.py develop >> log
+python -m testtools.run discover devportalbinary
+python -m testtools.run acceptance.tests