Merge lp:~james-w/linaro-image-tools/no-install-recommends into lp:linaro-image-tools/11.11

Proposed by James Westby
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~james-w/linaro-image-tools/no-install-recommends
Merge into: lp:linaro-image-tools/11.11
Diff against target: 10 lines (+1/-1)
1 file modified
linaro-hwpack-install (+1/-1)
To merge this branch: bzr merge lp:~james-w/linaro-image-tools/no-install-recommends
Reviewer Review Type Date Requested Status
Steve Langasek (community) Disapprove
Tom Gall (community) Approve
Review via email: mp+40106@code.launchpad.net

Description of the change

Hi,

This uses --no-install-recommends when installing a hwpack,
as hwpacks currently don't have recommended packages in them.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Tom Gall (tom-gall) wrote :

simple enough change and without any recommends in hwpacks currently sure shouldn't have negative effects.

review: Approve
Revision history for this message
Steve Langasek (vorlon) wrote :

AIUI, this is mutually incompatible with <https://code.launchpad.net/~james-w/linaro-image-tools/install-recommends/+merge/40118>, which would *add* the recommends into the hwpacks. I think the latter change is the one we want, not this one.

review: Disapprove

Unmerged revisions

160. By James Westby

Don't install recommended packages when installing a hwpack.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'linaro-hwpack-install'
2--- linaro-hwpack-install 2010-10-14 14:55:00 +0000
3+++ linaro-hwpack-install 2010-11-04 15:12:23 +0000
4@@ -118,5 +118,5 @@
5 else
6 packages=`cat "${HWPACK_DIR}"/manifest`
7 fi
8-sudo apt-get -o "$APT_GET_OPTIONS" install $packages
9+sudo apt-get -o "$APT_GET_OPTIONS" --no-install-recommends install $packages
10 echo "Done"

Subscribers

People subscribed via source and target branches